Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NetFx: Add workaround for unsupported HttpClientHandler.SslProtocols #58

Merged
merged 1 commit into from
Jul 5, 2023
Merged

NetFx: Add workaround for unsupported HttpClientHandler.SslProtocols #58

merged 1 commit into from
Jul 5, 2023

Conversation

flobernd
Copy link
Member

@flobernd flobernd commented Jul 5, 2023

While the HttpClientHandler.SslProtocols exists for NetFx, it is actually unsupported until net472.

This PR adds an (ugly) workaround.

@flobernd flobernd requested a review from Mpdreamz July 5, 2023 08:31
Mpdreamz
Mpdreamz approved these changes Jul 5, 2023
View reviewed changes
Copy link
Member

@Mpdreamz Mpdreamz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This project should really just use Elastic.Transport 😸

LGTM 👍

@flobernd flobernd merged commit 90fa59a into master Jul 5, 2023
2 checks passed
@Mpdreamz Mpdreamz deleted the netfx-http-ssl-fix branch July 5, 2023 09:03
@flobernd flobernd mentioned this pull request Jul 6, 2023
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mpdreamz Mpdreamz Mpdreamz approved these changes

Assignees
No one assigned
Labels
bug v0.4.1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@flobernd @Mpdreamz