Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't error when warnings are written over stderr #54

Merged
merged 3 commits into from
Jun 30, 2023

Conversation

Mpdreamz
Copy link
Member

@Mpdreamz Mpdreamz commented Jun 29, 2023

Found here:

https://github.com/elastic/elastic-ingest-dotnet/actions/runs/5414752220/jobs/9842253506?pr=38#step:6:1559

Where the ci environment has a JAVA_HOME and bootstrapping users fails because the command line tooling writes a warning over standard error:

warning: ignoring JAVA_HOME=/usr/lib/jvm/temurin-11-jdk-amd64; using ES_JAVA_HOME

Copy link
Member

@flobernd flobernd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Just a minor nitpick comment 😋

@Mpdreamz Mpdreamz merged commit 9d88cf6 into master Jun 30, 2023
2 checks passed
@Mpdreamz Mpdreamz deleted the fix/dont-error-on-warnings branch June 30, 2023 09:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants