Throw an explicit error when asStream is used with bulk helper #2078
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions bot
pushed a commit
that referenced
this pull request
Nov 16, 2023
(cherry picked from commit 4269197)
github-actions bot
pushed a commit
that referenced
this pull request
Nov 16, 2023
(cherry picked from commit 4269197)
JoshMock
added
apply-to-serverless
JoshMock
added
apply-to-serverless
JoshMock
added a commit
to elastic/elasticsearch-serverless-js
that referenced
this pull request
Mar 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
bulkhelper does not supportasStream, as it assumes the response will be parsed JSON rather than a raw stream. It currently takes a lot of debugging to understand why the helper fails in this case, so this adds an explicit check and throws an error with a clear message.Thanks to @achyutjhunjhunwala for catching this (pun intended)!