Fix AnalysisPatternTokenizer definition (#1828) #1967
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miramo
approved these changes
Aug 9, 2023
JoshMock
added a commit
to elastic/elasticsearch-specification
that referenced
this pull request
Aug 9, 2023
JoshMock
approved these changes
Aug 9, 2023
There was a problem hiding this comment.
I had to check the source verify that all three values can indeed be null. Good catch!
I've also opened elastic/elasticsearch-specification#2232 to ensure this change gets applied to all our clients.
Thanks for the contribution!
|
jenkins test this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1828 by changing
flag,groupandpatternas optional properties ofAnalysisPatternTokenizertype.