fix: add types to exports (v7.x) #1930
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JoshMock
approved these changes
Jul 7, 2023
|
Verified that all the failing/missing CI tests are unrelated to this change. Merging (finally)! |
JoshMock
pushed a commit
that referenced
this pull request
Jul 13, 2023
JoshMock
added a commit
that referenced
this pull request
Jul 13, 2023
Co-authored-by: Nicolas Morel <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
Enabling ESM mode with TypeScript seems to cause this error to appear:
Cannot find module '@elastic/elasticsearch' or its corresponding type declarations.(2307)We're not ready yet to upgrade to v8.x which is why I'm patching v7.x, but it seems this error is also present in this version, and I'm not sure how to fix it yet, maybe it's as simple as declaring
"type": "commonjs"in the package.json?