Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue fixing #847

Merged
merged 2 commits into from
Jul 16, 2024
Merged

Issue fixing #847

merged 2 commits into from
Jul 16, 2024

Conversation

l-trotta
Copy link
Contributor

@l-trotta l-trotta commented Jul 16, 2024

Update to the generated code from the latest specification. This includes elastic/elasticsearch-specification#2724, elastic/elasticsearch-specification#2721, and elastic/elasticsearch-specification#2720, which fixes #846, fixes #838, fixes #839.

@l-trotta l-trotta merged commit bd8d2f6 into main Jul 16, 2024
7 checks passed
@l-trotta l-trotta deleted the fixes-from-recent-spec branch July 16, 2024 17:15
@dadoonet
Copy link
Member

Hey!

Is there a way to know in which version this will be available?

@l-trotta
Copy link
Contributor Author

hey, all of these are breaking changes to the API, so they will be available in the next minor version, which is 8.15!

Copy link

The backport to 8.15 failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-8.15 8.15
# Navigate to the new working tree
cd .worktrees/backport-8.15
# Create a new branch
git switch --create backport-847-to-8.15
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick --mainline 1 bd8d2f69d39c014c52417ba6662c2a77e8a10348
# Push it to GitHub
git push --set-upstream origin backport-847-to-8.15
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-8.15

Then, create a pull request where the base branch is 8.15 and the compare/head branch is backport-847-to-8.15.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants