Implement StreamResponse
#110
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flobernd
force-pushed
the
streamresponse
branch
from
f977a9b
to
978cfb1
Compare
flobernd
force-pushed
the
streamresponse
branch
from
978cfb1
to
234765e
Compare
Mpdreamz
reviewed
Aug 6, 2024
| @@ -165,6 +169,10 @@ private async ValueTask<TResponse> RequestCoreAsync<TResponse>(bool isAsync, Req | |||
| response = requestData.ConnectionSettings.ProductRegistration.ResponseBuilder.ToResponse<TResponse> | |||
| (requestData, ex, statusCode, responseHeaders, responseStream, mimeType, contentLength, threadPoolStats, tcpStats); | |||
|
|
|||
| // Defer disposal of the response message | |||
| if (response is StreamResponse sr) | |||
There was a problem hiding this comment.
Ugly but i think its better to pass receive (as IDisposable) to ResponseBuilder.ToResponse. To ensure we inject to to StreamResponse's constructor.
If an exception happens in ToResponse() we might never set the finalizer.
There was a problem hiding this comment.
That's fine for me as well! The whole thing is a little bit "spaghetti" unfortunately due to the fact that the HttpRequestInvoker must know about StreamResponse etc. Will change this part later 🙂
Mpdreamz
reviewed
Aug 6, 2024
| @@ -118,6 +118,7 @@ private async ValueTask<TResponse> RequestCoreAsync<TResponse>(bool isAsync, Req | |||
| responseMessage = client.SendAsync(requestMessage, HttpCompletionOption.ResponseHeadersRead, cancellationToken).GetAwaiter().GetResult(); | |||
| #endif | |||
|
|
|||
| receive = responseMessage; | |||
Mpdreamz
approved these changes
Aug 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements the
StreamResponseclass that provides direct access to the response content stream.