Basic ringbuf event statistics #198
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds a new structure `ebpf_event_stats` where we accumulate stats, right now it only counts lost events vs non-lost events, but we can grow this in the future, like adding per type events if it's interesting enough. The print in EventsTrace is quite primitive as I believe this will only be used for debugging there, so heh. Choosing a name for `ebpf_ringbuf_write` was a bit tricky, I wanted to keep the same parameters but it had to be "different enough" that we could spot it with a naked eye. While here, adjust the enum of ebpf events to not skip that precious first bit.
haesbaert
added a commit
to elastic/quark
that referenced
this pull request
Jul 2, 2024
This commit includes the pending PR: elastic/ebpf#198 Once that is merged I'll rebase this, so ignore the elastic-ebpf/* bits. Pretty straighforward, contrary to kprobes which we get the counter on the data path, with ebpf we have to actually read it, so add a new ops for updating the counter, we should caution users to not hammer the reading, as it's real syscall. Tested by hacking quark-mon away.
nicholasberlin
approved these changes
Jul 2, 2024
mjwolf
approved these changes
Jul 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a new structure
ebpf_event_statswhere we accumulate stats, right now it only counts lost events vs non-lost events, but we can grow this in the future, like adding per type events if it's interesting enough.The print in EventsTrace is quite primitive as I believe this will only be used for debugging there, so heh.
Choosing a name for
ebpf_ringbuf_writewas a bit tricky, I wanted to keep the same parameters but it had to be "different enough" that we could spot it with a naked eye.While here, adjust the enum of ebpf events to not skip that precious first bit.