Skeleton headers for host isolation #130
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stanek-michal
commented
Aug 25, 2022
| @@ -405,7 +405,8 @@ int ebpf_set_verbose_logging() | |||
|
|
|||
| int ebpf_event_ctx__new(struct ebpf_event_ctx **ctx, | |||
| ebpf_event_handler_fn cb, | |||
| struct ebpf_event_ctx_opts opts) | |||
| struct ebpf_event_ctx_opts opts, | |||
| bool dry_run) | |||
There was a problem hiding this comment.
This addition doesn't really change functionality but I wanted to make this option more explicit in the code to prevent bugs or relying on a certain behavior in the function. We did in fact had bugs like this in this function before. The Host Isolation version of this also has a dryRun parameter.
lrishi
reviewed
Aug 25, 2022
Trinity2019
approved these changes
Aug 25, 2022
Co-authored-by: Lovel Rishi <[email protected]>
lrishi
force-pushed
the
host_isolation_skeleton_headers
branch
from
e74a59d
to
04ac43d
Compare
rhysre
approved these changes
Aug 31, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes required to use skeleton headers for host isolation.
It is still possible to use
*bpf.ofiles and the Host Isolation demos continue to use those.