-
Notifications
You must be signed in to change notification settings - Fork 333
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: skip build for APM Server if there are no code changes #3051
feat: skip build for APM Server if there are no code changes #3051
Conversation
docs/build-pr is the slowest job in apm-server CI pipeline and it is impacting significantly developer velocity when merging PRs. Update the buildkite pipeline to exit early if there are no docs changes. APM Server docs is actually in a separate repository (observability-docs) and the few remaining files are barely touched (except for the changelog)
A documentation preview will be available soon. Request a new doc build by commenting
If your PR continues to fail for an unknown reason, the doc build pipeline may be broken. Elastic employees can check the pipeline status here. |
@bmorelli25 you can extract the part of the script that checks the diff and run it locally. To test it on apm-server: I've checked a new branch, made a random commit with a code file. Result: $ GITHUB_PR_BASE_REPO=apm-server GITHUB_PR_TARGET_BRANCH=main sh diff.sh
main in apm-server has no docs changes Update docs/README.md: $ GITHUB_PR_BASE_REPO=apm-server GITHUB_PR_TARGET_BRANCH=main sh diff.sh
diff:
docs/README.md | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-) If you agree with this approach I can add support for other repositories |
I'd suggest to add support for other repositories gradually |
…lastic#3051)" This reverts commit 2fc87e4.
…elastic#3051)" (elastic#3062) This reverts commit 1b8c088.
docs/build-pr is the slowest job in apm-server CI pipeline and it is impacting significantly developer velocity when merging PRs. Update the buildkite pipeline to exit early if there are no docs changes.
APM Server docs is actually in a separate repository (observability-docs) and the few remaining files are barely touched (except for the changelog)