Move edit button out of heading elements #3049
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1966
This PR moves the edit button out of the heading elements in the body of the content (edit buttons were already added outside page titles in #3015). This is important because when the edit button is inside the heading element, technically the full text of the heading includes
edit
appended to the end of the intended heading text. This is getting picked up by Google, but may also cause unexpected results elsewhere including for users using screenreaders.Note: I opted for updating the HTML and using Bootstrap CSS classes to avoid having to bump the name (
-v1
to-v2
) of the CSS file. If the user gets the updated HTML with a cached version of the CSS and JavaScript files, the edit button should still be positioned correctly and work as expected.