Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🚧 [WIP] Remove attributes with case-sensitive names #2934

Closed
wants to merge 1 commit into from

Conversation

joepeeples
Copy link
Contributor

@joepeeples joepeeples commented Feb 9, 2024

🚧 WORK IN PROGRESS — More details to come soon. Please hold off on reviewing or commenting.


Contributes to elastic/security-docs#4754 by removing attributes with case-sensitive names/keys. AsciiDoc doesn't actually support uppercase attribute names, and these legacy attributes are causing incorrect capitalization of the term "data view" throughout the docs.

Previews

[add pages to test]

Related

  • https://github.com/elastic/docs.elastic.co/pull/205 — Removes equivalent variables from docs.elastic.co. Those variables aren't causing trouble because Docsmobile seems to support uppercase variable names, but they're still legacy variables that we shouldn't encourage anyone to use.

@joepeeples joepeeples added bug Something that does not look or behave correctly asciidoc Asciidoc and our Asciidoctor extensions labels Feb 9, 2024
@joepeeples joepeeples self-assigned this Feb 9, 2024
Copy link

github-actions bot commented Feb 9, 2024

A documentation preview will be available soon.

Request a new doc build by commenting
  • Rebuild this PR: run docs-build
  • Rebuild this PR and all Elastic docs: run docs-build rebuild

run docs-build is much faster than run docs-build rebuild. A rebuild should only be needed in rare situations.

If your PR continues to fail for an unknown reason, the doc build pipeline may be broken. Elastic employees can check the pipeline status here.

@joepeeples joepeeples changed the title Remove attributes with case-sensitive names 🚧 [WIP] Remove attributes with case-sensitive names Feb 9, 2024
@joepeeples
Copy link
Contributor Author

Closing as duplicate of #2963.

@joepeeples joepeeples closed this Mar 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
asciidoc Asciidoc and our Asciidoctor extensions bug Something that does not look or behave correctly
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant