Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jenkins/Buildkite branch comparison build step #2863

Merged
merged 1 commit into from
Dec 13, 2023

Conversation

nkammah
Copy link
Contributor

@nkammah nkammah commented Dec 12, 2023

No description provided.

Copy link

A documentation preview will be available soon.
Help us out by validating the Buildkite preview and reporting issues here.

@nkammah nkammah changed the title Add script comparison Jenkins/Buildkite branch comparison build step Dec 12, 2023
@nkammah nkammah marked this pull request as ready for review December 12, 2023 18:20
Copy link
Member

@bmorelli25 bmorelli25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks neat! Thanks for putting this together. Is there any way to test it?

Copy link
Member

@gtback gtback left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't tried to run this, but it seems like it would be really useful 😁

fi

# Let's sleep a few minutes to let Jenkins catch-up
sleep 3m
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe check if it already exists, and proceed immediately if it does, otherwise wait 3 minutes and try again?

@bmorelli25
Copy link
Member

Should the Buildkite vs Jenkins diff be this big?

Showing 22,628 changed files with 4,737,324 additions and 6,996 deletions.

@nkammah
Copy link
Contributor Author

nkammah commented Dec 13, 2023

Should the Buildkite vs Jenkins diff be this big?

Showing 22,628 changed files with 4,737,324 additions and 6,996 deletions.

that's because I used this PR to test it against a bunch of other repos/PT :D

@nkammah
Copy link
Contributor Author

nkammah commented Dec 13, 2023

I will merge this is for now- there are other optimizations we could do, but I have already spent too much time on this for a script that will go away once the validation is over, and want to start reaping off the benefits of it while (potentially) incrementally making this better, eg:

  • (optimization) check if the Jenkins branch exists and then sleep if it does not
  • (better reporting) report violations in slack

@nkammah nkammah merged commit 3e4f034 into master Dec 13, 2023
5 checks passed
@nkammah nkammah deleted the compare-bk-jenkins-branches branch December 13, 2023 01:04
@thbkrkr
Copy link
Contributor

thbkrkr commented Jan 11, 2024

there are other optimizations we could do, but I have already spent too much time on this for a script that will go away once the validation is over,

Out of curiosity, how long will validation take? This script seems to increase the duration by almost +50% (from ~15min to ~24min). We have a PR build that takes ~15 minutes, so now we're waiting for the doc PR build, rather than ours.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants