Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch from master to main for kibana repo #2211

Merged
merged 2 commits into from
Sep 13, 2021
Merged

Conversation

lcawl
Copy link
Contributor

@lcawl lcawl commented Sep 3, 2021

Relates to elastic/kibana#97827

This PR pulls content from the "main" branch of the kibana repo instead of the "master" branch.

@lcawl lcawl requested a review from gtback September 7, 2021 18:19
Copy link
Member

@gtback gtback left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is fine, as long as we can quickly revert if anything goes wrong. With this change, we're still building a "master" version, even though it's using the "main" branch (which for now is just automatically updated with all commits to master). I believe the Kibana link checking only worries about the name of the files on disk (the "version", not the "branch"), so this change is effectively a no-op as far as that's concerned.

@tylersmalley
Copy link
Contributor

Thanks, @lcawl - reach out if you have any questions. The main branch should exist now and is being sync'd.

@lcawl lcawl merged commit 43369f0 into elastic:master Sep 13, 2021
@lcawl lcawl deleted the kibana-main branch September 13, 2021 23:15
lcawl added a commit to lcawl/docs that referenced this pull request Sep 13, 2021
@lcawl
Copy link
Contributor Author

lcawl commented Sep 14, 2021

This change was reverted in #2215

lcawl added a commit to lcawl/docs that referenced this pull request Sep 16, 2021
lcawl added a commit to lcawl/docs that referenced this pull request Oct 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants