Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[New] ROT encoded Python Script Execution #4084

Merged
merged 6 commits into from
Sep 17, 2024
Merged

[New] ROT encoded Python Script Execution #4084

merged 6 commits into from
Sep 17, 2024

Conversation

Samirbous
Copy link
Contributor

@Samirbous Samirbous commented Sep 17, 2024

windows:

image

macos:
image

@Samirbous Samirbous added OS: macOS Rule: New Proposal for new rule OS: Windows windows related rules labels Sep 17, 2024
@Samirbous Samirbous self-assigned this Sep 17, 2024
@protectionsmachine
Copy link
Collaborator

Rule: New - Guidelines

These guidelines serve as a reminder set of considerations when proposing a new rule.

Documentation and Context

  • Detailed description of the rule.
  • List any new fields required in ECS/data sources.
  • Link related issues or PRs.
  • Include references.

Rule Metadata Checks

  • creation_date matches the date of creation PR initially merged.
  • min_stack_version should support the widest stack versions.
  • name and description should be descriptive and not include typos.
  • query should be inclusive, not overly exclusive, considering performance for diverse environments. Non ecs fields should be added to non-ecs-schema.json if not available in an integration.
  • min_stack_comments and min_stack_version should be included if the rule is only compatible starting from a specific stack version.
  • index pattern should be neither too specific nor too vague, ensuring it accurately matches the relevant data stream (e.g., use logs-endpoint.process-* for process data).
  • integration should align with the index. If the integration is newly introduced, ensure the manifest, schemas, and new_rule.yaml template are updated.
  • setup should include the necessary steps to configure the integration.
  • note should include any additional information (e.g. Triage and analysis investigation guides, timeline templates).
  • tags should be relevant to the threat and align/added to the EXPECTED_RULE_TAGS in the definitions.py file.
  • threat, techniques, and subtechniques should map to ATT&CK always if possible.

New BBR Rules

  • building_block_type should be included if the rule is a building block and the rule should be located in the rules_building_block folder.
  • bypass_bbr_timing should be included if adding custom lookback timing to the rule.

Testing and Validation

  • Provide evidence of testing and detecting the expected threat.
  • Check for existence of coverage to prevent duplication.

Copy link
Contributor

@DefSecSentinel DefSecSentinel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Samirbous Samirbous merged commit def2a9e into main Sep 17, 2024
9 checks passed
@Samirbous Samirbous deleted the python-exec branch September 17, 2024 15:52
protectionsmachine pushed a commit that referenced this pull request Sep 17, 2024
* [New] ROT encoded Python Script Execution

* Update defense_evasion_encoding_rot13_python_script.toml

* ++

* Update defense_evasion_encoding_rot13_python_script.toml

---------

Co-authored-by: Colson Wilhoit <[email protected]>

(cherry picked from commit def2a9e)
protectionsmachine pushed a commit that referenced this pull request Sep 17, 2024
* [New] ROT encoded Python Script Execution

* Update defense_evasion_encoding_rot13_python_script.toml

* ++

* Update defense_evasion_encoding_rot13_python_script.toml

---------

Co-authored-by: Colson Wilhoit <[email protected]>

(cherry picked from commit def2a9e)
protectionsmachine pushed a commit that referenced this pull request Sep 17, 2024
* [New] ROT encoded Python Script Execution

* Update defense_evasion_encoding_rot13_python_script.toml

* ++

* Update defense_evasion_encoding_rot13_python_script.toml

---------

Co-authored-by: Colson Wilhoit <[email protected]>

(cherry picked from commit def2a9e)
protectionsmachine pushed a commit that referenced this pull request Sep 17, 2024
* [New] ROT encoded Python Script Execution

* Update defense_evasion_encoding_rot13_python_script.toml

* ++

* Update defense_evasion_encoding_rot13_python_script.toml

---------

Co-authored-by: Colson Wilhoit <[email protected]>

(cherry picked from commit def2a9e)
protectionsmachine pushed a commit that referenced this pull request Sep 17, 2024
* [New] ROT encoded Python Script Execution

* Update defense_evasion_encoding_rot13_python_script.toml

* ++

* Update defense_evasion_encoding_rot13_python_script.toml

---------

Co-authored-by: Colson Wilhoit <[email protected]>

(cherry picked from commit def2a9e)
protectionsmachine pushed a commit that referenced this pull request Sep 17, 2024
* [New] ROT encoded Python Script Execution

* Update defense_evasion_encoding_rot13_python_script.toml

* ++

* Update defense_evasion_encoding_rot13_python_script.toml

---------

Co-authored-by: Colson Wilhoit <[email protected]>

(cherry picked from commit def2a9e)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport: auto OS: macOS OS: Windows windows related rules Rule: New Proposal for new rule
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants