Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create an Issue in Kibana for MITRE Updates #3796

Merged
merged 23 commits into from
Jul 2, 2024
Merged

Conversation

shashank-elastic
Copy link
Contributor

@shashank-elastic shashank-elastic commented Jun 17, 2024

Issues

#3100

Summary

  • Most of the code logic was originally pinned in the issue.
  • We need to check the GitHub token and its permission to create issue in kibana repository
  • We have moved to use market place changed files to fetch filename as opposed to git diff originally ideated.
  • We have added an activity type for pull_request : [opened].
    • If no activity types are specified, the workflow runs when a pull request is opened or reopened or when the head branch of the pull request is updated, creating duplicate issues in kibana which is not required.
    • The workflow will run only when the PR is opened at the first time.

Testing

Copy link
Contributor

@Mikaayenson Mikaayenson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't tell how this was tested. Do you have screenshots or any evidence that this works?

.github/workflows/kibana-mitre-update.yml Outdated Show resolved Hide resolved
Copy link
Contributor

@eric-forte-elastic eric-forte-elastic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Manual review, looks good to me! 👍

@shashank-elastic shashank-elastic merged commit 30ffe00 into main Jul 2, 2024
9 checks passed
@shashank-elastic shashank-elastic deleted the issue-3100 branch July 2, 2024 13:27
protectionsmachine pushed a commit that referenced this pull request Jul 2, 2024
protectionsmachine pushed a commit that referenced this pull request Jul 2, 2024
protectionsmachine pushed a commit that referenced this pull request Jul 2, 2024
protectionsmachine pushed a commit that referenced this pull request Jul 2, 2024
protectionsmachine pushed a commit that referenced this pull request Jul 2, 2024
protectionsmachine pushed a commit that referenced this pull request Jul 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FR] Add GitHub Action to Open Issue in Kibana for ATT&CK Version Update
5 participants