Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[main] Fix handling of custom Endpoint when using S3 + SQS #39722

Closed
wants to merge 1 commit into from

Conversation

strawgate
Copy link
Contributor

@strawgate strawgate commented May 24, 2024

Fix issues described in #39706 that prevent using a custom endpoint with S3 + SQS.

Users can workaround this issue via S3 bucket polling. The S3 bucket polling still works just fine with a custom endpoint, it's just adding in SQS where it breaks. We need to publish a elastic/integrations#9865

Work required for Main:

  • Only use a custom Endpoint Resolver if the Endpoint doesn't start with S3.
  • Parse Endpoints with custom domains in the format of https://s3.us-east-1.abc.xyz so users don't have to specify a region

@strawgate strawgate requested a review from a team as a code owner May 24, 2024 13:22
@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label May 24, 2024
@botelastic
Copy link

botelastic bot commented May 24, 2024

This pull request doesn't have a Team:<team> label.

Copy link
Contributor

mergify bot commented May 24, 2024

This pull request does not have a backport label.
If this is a bug or security fix, could you label this PR @strawgate? 🙏.
For such, you'll need to label your PR with:

  • The upcoming major version of the Elastic Stack
  • The upcoming minor version of the Elastic Stack (if you're not pushing a breaking change)

To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-v8./d.0 is the label to automatically backport to the 8./d branch. /d is the digit

@strawgate
Copy link
Contributor Author

@faec can we make sure these items are fixed in your refactor as well? i.e. the ones in #39709 that arent already fixed?

@dinofizz
Copy link

We currently use AWS VPC interface endpoints for SQS and S3. For SQS we do have "Private DNS names" enabled, and so we do not need to set an endpoint for SQS (i.e. traffic to sqs.eu-west-1.amazonaws.com is automatically routed to the internal VPC endpoint). However we do not have private DNS names enabled on S3 interface endpoints, and so here our endpoint hostname is https://bucket.vpce-07bedb45c8767nd.s3.eu-west-1.vpce.amazonaws.com.

It's not obvious to me from the comments if this change will enable us to use the input in this way. Ideally we would just set (or omit) an endpoint per AWS service, which would allow us to use a "https://bucket.vpce-..." endpoint for S3 and not use an endpoint for SQS.

@v1v v1v added the backport-8.x Automated backport to the 8.x branch with mergify label Sep 11, 2024
@strawgate
Copy link
Contributor Author

this was not supposed to merge, it was just an example for how to include it post s3/sqs refactor, ill close the PR

@strawgate strawgate closed this Sep 13, 2024
@strawgate
Copy link
Contributor Author

We currently use AWS VPC interface endpoints for SQS and S3. For SQS we do have "Private DNS names" enabled, and so we do not need to set an endpoint for SQS (i.e. traffic to sqs.eu-west-1.amazonaws.com is automatically routed to the internal VPC endpoint). However we do not have private DNS names enabled on S3 interface endpoints, and so here our endpoint hostname is https://bucket.vpce-07bedb45c8767nd.s3.eu-west-1.vpce.amazonaws.com.

It's not obvious to me from the comments if this change will enable us to use the input in this way. Ideally we would just set (or omit) an endpoint per AWS service, which would allow us to use a "https://bucket.vpce-..." endpoint for S3 and not use an endpoint for SQS.

The endpoint handling is all or nothing, so I do not believe this change does not offer setting a specific endpoint for one component or the other.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-8.x Automated backport to the 8.x branch with mergify needs_team Indicates that the issue/PR needs a Team:* label
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants