Specify when flush returns unsuccessfully #623
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
💚 Build Succeeded
Expand to view the summary
Build stats
|
estolfo
reviewed
Mar 24, 2022
Co-authored-by: Emily S <[email protected]>
estolfo
approved these changes
Mar 24, 2022
basepi
reviewed
Mar 24, 2022
| In the edge case where the extension takes too much time to respond (e.g. if there's a lenghy GC pause), | ||
| the `flush` method should return after a timeout. | ||
|
|
||
| The default timeout is 1s. |
There was a problem hiding this comment.
As a data point for what is currently happening in the agents, we use api_request_time as our flush timeout, which defaults to 10s.
That's likely too long, especially for Lambda. But I'm thinking we should create a new config option so this is configurable (and divorced from api_request_time).
There was a problem hiding this comment.
Suggested change
| The default timeout is 1s. | |
| | | | | |
| |----------------|---| | |
| | Type | [duration](configuration.md#configuration-value-types) | | |
| | Default | `1s` | | |
| | Dynamic | `true` | |
trentm
reviewed
Mar 24, 2022
Co-authored-by: Trent Mick <[email protected]>
felixbarny
commented
Mar 24, 2022
| @@ -291,3 +291,17 @@ Therefore, the Lambda instrumentation has to ensure that data is flushed in a bl | |||
|
|
|||
| Some Lambda functions will use the custom-built Lambda extension that allows the agent to send its data locally. The extension asynchronously forwards the data it receives from the agent to the APM server so the Lambda function can return its result with minimal delay. In order for the extension to know when it can flush its data, it must receive a signal indicating that the lambda function has completed. There are two possible signals: one is via a subscription to the AWS Lambda Logs API and the other is an agent intake request with the query param `flushed=true`. A signal from the agent is preferrable because there is an inherent delay with the sending of the Logs API signal. | |||
| Therefore, the agent must send its final intake request at the end of the function invocation with the query param `flushed=true`. In case there is no more data to send at the end of the function invocation, the agent must send an empty intake request with this query param. | |||
|
|
|||
| ### Flush timeout | |||
There was a problem hiding this comment.
This option is used by the Java agent already. See https://www.elastic.co/guide/en/apm/agent/java/current/config-serverless.html#config-data-flush-timeout
Suggested change
| ### Flush timeout | |
| ### Configuration option `data_flush_timeout` |
| In the edge case where the extension takes too much time to respond (e.g. if there's a lenghy GC pause), | ||
| the `flush` method should return after a timeout. | ||
|
|
||
| The default timeout is 1s. |
There was a problem hiding this comment.
Suggested change
| The default timeout is 1s. | |
| | | | | |
| |----------------|---| | |
| | Type | [duration](configuration.md#configuration-value-types) | | |
| | Default | `1s` | | |
| | Dynamic | `true` | |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CODEOWNERS)To auto-merge the PR, add
/schedule YYYY-MM-DDto the PR description.