Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(buildkite/slack): use github secrets #1161

Merged
merged 5 commits into from
Jun 5, 2024
Merged

feat(buildkite/slack): use github secrets #1161

merged 5 commits into from
Jun 5, 2024

Conversation

v1v
Copy link
Member

@v1v v1v commented Jun 4, 2024 •
edited
Loading

Move away from Vault secrets

Next steps:

  • use keyless

Tests

I created a feature branch called test/github-secrets to test this:

v1v
v1v commented Jun 5, 2024
View reviewed changes
.github/workflows/release.yml Outdated Show resolved Hide resolved
.github/workflows/release.yml Outdated Show resolved Hide resolved
.github/workflows/release.yml Outdated Show resolved Hide resolved
.github/workflows/release.yml Outdated Show resolved Hide resolved
@v1v v1v marked this pull request as ready for review June 5, 2024 14:15
@v1v v1v requested review from a team June 5, 2024 14:15
@v1v v1v self-assigned this Jun 5, 2024
@v1v v1v merged commit 4935fd4 into elastic:main Jun 5, 2024
169 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@reakaleek reakaleek reakaleek approved these changes

Assignees

@v1v v1v

Labels
agent-php
Projects
APM-Agents (OLD)
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@v1v @reakaleek