github-actions: use github secrets for azure #2375
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mpdreamz
approved these changes
Jun 12, 2024
Mpdreamz
approved these changes
Jun 12, 2024
Mpdreamz
requested changes
Jun 12, 2024
|
Good catch! I've just converted those secrets to env variables and https://github.com/elastic/apm-agent-dotnet/actions/runs/9483799301?pr=2376 should verify if it works as expected |
Mpdreamz
approved these changes
Jun 12, 2024
|
LGTM! The azure tests itself are still failing because I think our SP might no longer have permissions to delete resources? Will need to investigate on a follow up PR that re-enables this tests again. |
reakaleek
approved these changes
Jun 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No more vault access
I created a feature branch and it works