-
Notifications
You must be signed in to change notification settings - Fork 207
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Simplify CI Testing #2365
Simplify CI Testing #2365
Conversation
(cherry picked from commit 65e48ce42148a5c87c351e68cb334f6709f924c4)
(cherry picked from commit 607fe23f62965170cd77d250550d2c4ea555d0ad)
(cherry picked from commit 6b36b9ad8873ffc5c90d2728eef68cc51948be9f)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor comments, other than that LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
qq: I see the IIS
test-suite, but no changes in https://github.com/elastic/apm-agent-dotnet/blob/main/.github/workflows/test-windows-iis.yml , is that expected?
Good catch! I was planning to follow up this and #2363 merging IIS into I need to ensure we set some environment variables automatically when calling |
Ensures we can call the test suite grouping we partitioned on CI locally easily as well:
StartupHooks
andProfiler
will build their dependencies automatically simplifying reproducing these further. You can use--clean false
locally to run the tests multiple times without cleaning and rebuilding the artifacts (including profiler and agent zips).This now also more clearly separates
Unit
fromIntegrations
. Allowing us to more clearly run faster tests locally during our development loop for quick validations.Lastly this moves us over to https://github.com/Tyrrrz/GitHubActionsTestLogger for github test reporting. This allows us to move away from stashing xml files and we can thus remove the
-reporter.yml
workflows.