Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify CI Testing #2365

Merged
merged 11 commits into from
May 28, 2024
Merged

Simplify CI Testing #2365

merged 11 commits into from
May 28, 2024

Conversation

Mpdreamz
Copy link
Member

@Mpdreamz Mpdreamz commented May 27, 2024

Ensures we can call the test suite grouping we partitioned on CI locally easily as well:

# the default is Unit e.g so the first two are equivalent
./build.sh test 
./build.sh test --test-suite Unit
./build.sh test --test-suite Integrations
./build.sh test --test-suite Profiler
./build.sh test --test-suite Azure
./build.sh test --test-suite IIS
./build.sh test --test-suite StartupHooks

StartupHooks and Profiler will build their dependencies automatically simplifying reproducing these further. You can use --clean false locally to run the tests multiple times without cleaning and rebuilding the artifacts (including profiler and agent zips).

This now also more clearly separates Unit from Integrations. Allowing us to more clearly run faster tests locally during our development loop for quick validations.

Lastly this moves us over to https://github.com/Tyrrrz/GitHubActionsTestLogger for github test reporting. This allows us to move away from stashing xml files and we can thus remove the -reporter.yml workflows.

(cherry picked from commit 65e48ce42148a5c87c351e68cb334f6709f924c4)
(cherry picked from commit 607fe23f62965170cd77d250550d2c4ea555d0ad)
(cherry picked from commit 6b36b9ad8873ffc5c90d2728eef68cc51948be9f)
@Mpdreamz Mpdreamz changed the title fix/simplify testing Simplify CI Testing May 27, 2024
gregkalapos
gregkalapos previously approved these changes May 27, 2024
v1v
v1v previously approved these changes May 27, 2024
Copy link
Member

@v1v v1v left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comments, other than that LGTM

.github/workflows/test-linux.yml Outdated Show resolved Hide resolved
.github/workflows/test-linux.yml Outdated Show resolved Hide resolved
.github/workflows/test-windows.yml Outdated Show resolved Hide resolved
.github/workflows/test-windows.yml Outdated Show resolved Hide resolved
.github/workflows/test-windows.yml Outdated Show resolved Hide resolved
@Mpdreamz Mpdreamz dismissed stale reviews from v1v and gregkalapos via 7b3952d May 28, 2024 12:02
@Mpdreamz Mpdreamz requested review from v1v and gregkalapos May 28, 2024 12:04
v1v
v1v previously approved these changes May 28, 2024
Copy link
Member

@v1v v1v left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

qq: I see the IIS test-suite, but no changes in https://github.com/elastic/apm-agent-dotnet/blob/main/.github/workflows/test-windows-iis.yml , is that expected?

@Mpdreamz
Copy link
Member Author

Good catch! I was planning to follow up this and #2363 merging IIS into test-windows.yml too.

I need to ensure we set some environment variables automatically when calling ./build.bat IIS too in that follow up PR.

@Mpdreamz Mpdreamz merged commit ef9d458 into main May 28, 2024
11 checks passed
@Mpdreamz Mpdreamz deleted the fix/simplify-testing branch May 28, 2024 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants