Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added check that Open Telemetry Bridge is enable and only then displa… #2356

Merged
merged 3 commits into from
May 23, 2024

Conversation

zviedris
Copy link
Contributor

@zviedris zviedris commented May 16, 2024

Add additional check so warning is only displayed if Open Telemetry Bridge is enabled - now it is displayed also in cases if Open Telemetry Bridge is disabled and it is misleading.

Check is same as in EnsureElasticActivityStarted

Copy link

👋 @zviedris Thanks a lot for your contribution!

It may take some time before we review a PR, so even if you don’t see activity for some time, it does not mean that we have forgotten about it.

Every once in a while we go through a process of prioritization, after which we are focussing on the tasks that were planned for the upcoming milestone. The prioritization status is typically reflected through the PR labels. It could be pending triage, a candidate for a future milestone, or have a target milestone set to it.

Copy link
Member

@Mpdreamz Mpdreamz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, will eliminate some noise in our logs. Thank you @zviedris for the contribution!

@Mpdreamz
Copy link
Member

run docs-build

@Mpdreamz Mpdreamz merged commit ff221d6 into elastic:main May 23, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants