Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move timestamps to CSS div:before statements #133

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

dltj
Copy link

@dltj dltj commented Jan 7, 2023

Addresses #129

If @seconddayout is like me, the issue is with the YouTube video transcripts. Although it looks like one can select across <div>s...

image

...when Hypothesis grabs the text, it only gets the part in the first <div>:

image

I ran into this same sort of problem when I was creating an equivalent to droppdf for podcasts (see unchecked-transcript). To solve the problem, I put the timestamp into a CSS :before declaration. See this example for what it looks like in practice—notably the first Hypothesis annotation that crosses three <div>s.

This pull request is my best guess at how this solution would work with droppdf. Unfortunately, I couldn't get all of the droppdf prerequisites to install on my machine, so I wasn't able to do an end-to-end test of the code changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant