Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show on App Launch: Add pixels #5040

Open
wants to merge 4 commits into
base: feature/mike/show-on-app-launch/add-more-tests
Choose a base branch
from

Conversation

mikescamell
Copy link
Contributor

@mikescamell mikescamell commented Sep 19, 2024

Task/Issue URL: https://app.asana.com/0/1207908166761516/1208156273709090/f

Description

Adds three pixels to the Show on App Launch feature:

  • When the Show on App Launch screen is opened from General settings (temporary pixel)
  • When selecting a new Show on App Launch option (temporary pixel)
  • When the daily pixel is fired (permanent pixel)

Steps to test this PR

App launch pressed pixel

  • Go to general settings screen
  • Click “Show on App Launch"
  • Checks logs to if m_settings_general_app_launch_pressed is sent

New option selected pixel

  • Go to Show on App Launch screen
  • Click “New Tab Page”
  • Check logs for m_settings_general_app_launch_new_tab_page_selected pixel
  • Click “Specific Page"
  • Check logs for m_settings_general_app_launch_specific_page_selected pixel
  • Click “Last Opened Tab”
  • Check logs for m_settings_general_app_launch_last_opened_tab_selected pixel

Daily pixel

  • Launch app
  • Check daily pixel for “launch_screen” and check it’s the same as what you have selected for “Show on App Launch"

UI changes

N/A

Copy link
Contributor Author

mikescamell commented Sep 19, 2024

seeing as this is the only place I want to synchronously get the show on app launch option I chose to runBlocking when getting the setting here rather than adding a function to the DataStore
@mikescamell mikescamell force-pushed the feature/mike/show-on-app-launch/add-more-tests branch from 4c6b0e2 to 466de55 Compare September 19, 2024 14:48
@mikescamell mikescamell force-pushed the feature/mike/show-on-app-launch/add-pixels branch from 6ed635a to ee7c723 Compare September 19, 2024 14:48
@mikescamell mikescamell marked this pull request as ready for review September 19, 2024 14:52
@anikiki anikiki self-assigned this Sep 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants