Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Async graphql qol improvements #18

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Async graphql qol improvements #18

wants to merge 3 commits into from

Conversation

dsimon96
Copy link
Owner

Small stuff to make our code less messy

  • Adopt async_graphql's Result type wherever applicable, to make error handling simpler (At some point we'll need to properly encapsulate errors, but not yet)
  • Leverage async_graphql's ID type's ID->Uuid conversion

@dsimon96 dsimon96 self-assigned this Dec 30, 2020
@dsimon96 dsimon96 force-pushed the async-graphql-qol-improvements branch from 0ebc24c to b79b4d8 Compare January 5, 2021 20:24
okel17
okel17 approved these changes Feb 12, 2022
View reviewed changes
Copy link
Collaborator

@okel17 okel17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@okel17 okel17 okel17 approved these changes

@vikshanker vikshanker Awaiting requested review from vikshanker

Assignees

@dsimon96 dsimon96

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dsimon96 @okel17