Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding clicommandlineparser and cli-migrate to dnceng mirroring #368

Merged
merged 1 commit into from
Sep 26, 2018

Conversation

livarcocc
Copy link
Contributor

@chcosta
Copy link
Member

chcosta commented Sep 26, 2018

@dagood @mmitche , can you review / merge?

@livarcocc
Copy link
Contributor Author

Once this is merged, can we trigger a manual mirroring, so that the repo gets some content ahead of the next PR being merged?

@@ -854,6 +854,8 @@
"https://github.com/dotnet/sdk/blob/rel/**/*",
"https://github.com/dotnet/sdk/blob/release/**/*",
"https://github.com/dotnet/dotnet-cli-archiver/blob/master/**/*",
"https://github.com/dotnet/cli-migrate/blob/master/**/*",
"https://github.com/dotnet/clicommandlineparser/blob/master/**/*",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why no release branches?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don’t have a release branch moving to VSTS right now.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok. It'd be fine to add the trigger preemptively, if you want, but this is fine.

@dagood
Copy link
Member

dagood commented Sep 26, 2018

Maestro doesn't have a mechanism for that (#99), but you can queue the underlying build yourself and fill in the parameters manually. I think https://github.com/dotnet/versions/tree/master/Maestro#subscriptionsjson is still an accurate enough description of the file.

If possible, it would be much easier to push a dummy commit. (Unfortunately it does have to make an actual change, because the **/* has to match something. #110)

@dagood dagood merged commit fe96723 into dotnet:master Sep 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants