Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[IGNORE] add 9.0 templates #5686

Draft
wants to merge 9 commits into
base: main
Choose a base branch
from
Draft

[IGNORE] add 9.0 templates #5686

wants to merge 9 commits into from
+4,892 −33

Conversation

radical
Copy link
Member

@radical radical commented Sep 11, 2024 •
edited by dotnet-policy-service bot
Loading

Description

Please include a summary of the changes and the related issue. Please also include relevant motivation and context. List any dependencies that are required for this change.

Fixes # (issue)

Checklist

  • Is this feature complete?
    • Yes. Ready to ship.
    • No. Follow-up changes expected.
  • Are you including unit tests for the changes and scenario tests if relevant?
    • Yes
    • No
  • Did you add public API?
    • Yes
      • If yes, did you have an API Review for it?
        • Yes
        • No
      • Did you add <remarks /> and <code /> elements on your triple slash comments?
        • Yes
        • No
    • No
  • Does the change make any security assumptions or guarantees?
    • Yes
      • If yes, have you done a threat model and had a security review?
        • Yes
        • No
    • No
  • Does the change require an update in our Aspire docs?
    • Yes
      • Link to aspire-docs issue:
    • No
Microsoft Reviewers: Open in CodeFlow

@radical
wip
bffcd7a
@radical
Merge remote-tracking branch 'origin/main' into templates9
be10dc2
@radical
Merge remote-tracking branch 'origin/main' into templates9
706d776
@radical
Initial - templates for aspire9
511c916 
- rename `src/Aspire.ProjectTemplates` to `src/Aspire.ProjectTemplates.net8`
- duplicate `src/Aspire.ProjectTemplates8` to `src/Aspire.ProjectTemplates.net9`
    - update the `-f` parameter to `net9.0`
    - update the precedence
    - update `identity` to be like `Aspire.ServiceDefaults.CSharp.9.0`
@radical
rename Aspire.ProjectTemplates.netX to Aspire.ProjectTemplates.9.0.netX
a5d6f68
@build-analysis build-analysis bot mentioned this pull request Sep 19, 2024
Open
@build-analysis build-analysis bot mentioned this pull request Sep 20, 2024
Open
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eerhardt eerhardt Awaiting requested review from eerhardt eerhardt will be requested when the pull request is marked ready for review eerhardt is a code owner

@joperezr joperezr Awaiting requested review from joperezr joperezr will be requested when the pull request is marked ready for review joperezr is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
area-templates
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@radical