GameSettings: Disable GPU Texture Decoding when needed #13058
+38
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The change itself is fine and LGTM, but having two separate PRs handling the same thing is a bit redundant IMO, I'd suggest closing the other one and bundling the GMS.ini change on this PR as well... |
|
I strongly prefer not to snipe someone's PR, especially when it inspired this one. |
|
Oh, sorry, haven't noticed you're not the author of the other PR. In that case this is fine, I guess... |
|
I've closed the PR that's only about GMS because I didn't know what I was doing and got a merge commit in the mix. Sorry for the trouble. Thank you. |
Dentomologist
force-pushed
the
gamesettings_disable_gpu_texture_decoding_when_needed
branch
from
301f939
to
da60b38
Compare
Arbitrary Mipmap Detection doesn't work when GPU Texture Decoding is enabled, so disable GPU Texture Decoding for games where the .ini enables Arbitrary Mipmap Detection. Co-authored-by: jeremyie <[email protected]>
Dentomologist
force-pushed
the
gamesettings_disable_gpu_texture_decoding_when_needed
branch
from
da60b38
to
b1d54e4
Compare
|
Sorry for the trouble myself. I've added GMS.ini and made you a coauthor for this commit. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Arbitrary Mipmap Detection doesn't work when GPU Texture Decoding is enabled, so disable GPU Texture Decoding for games where the .ini enables Arbitrary Mipmap Detection.
This skips GMS.ini because that's handled in #13056.