-
Notifications
You must be signed in to change notification settings - Fork 5.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
introduce config --images-to-build #8995
base: main
Are you sure you want to change the base?
Conversation
99ee7df
to
fcb774a
Compare
Ability to filter images by services which uses built images It solves docker#8994 ( option 2 ) Signed-off-by: abdennour <[email protected]> Developer Certificate of Origin Version 1.1 Copyright (C) 2004, 2006 The Linux Foundation and its contributors. Everyone is permitted to copy and distribute verbatim copies of this license document, but changing it is not allowed. Developer's Certificate of Origin 1.1 By making a contribution to this project, I certify that: (a) The contribution was created in whole or in part by me and I have the right to submit it under the open source license indicated in the file; or (b) The contribution is based upon previous work that, to the best of my knowledge, is covered under an appropriate open source license and I have the right under that license to submit that work with modifications, whether created in whole or in part by me, under the same open source license (unless I am permitted to submit under a different license), as indicated in the file; or (c) The contribution was provided directly to me by some other person who certified (a), (b) or (c) and I have not modified it. (d) I understand and agree that this project and the contribution are public and that a record of the contribution (including all personal information I submit with it, including my sign-off) is maintained indefinitely and may be redistributed consistent with this project or the open source license(s) involved.
fcb774a
to
3bf943e
Compare
code looks good, but I'm not fan for adding an option that only applies to the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It doesn't work as defined in the scenario 2 of #8995
> ./bin/docker-compose compose -f ~/sources/awesome-compose/nginx-golang/docker-compose.yml convert --only-built
services:
backend:
build:
context: /Users/glours/sources/awesome-compose/nginx-golang/backend
dockerfile: Dockerfile
networks:
default: null
frontend:
build:
context: /Users/glours/sources/awesome-compose/nginx-golang/frontend
dockerfile: Dockerfile
depends_on:
backend:
condition: service_started
networks:
default: null
ports:
- mode: ingress
target: 80
published: 80
protocol: tcp
networks:
default:
name: nginx-golang_default
> ./bin/docker-compose compose -f ~/sources/awesome-compose/nginx-golang/docker-compose.yml convert --volumes --only-built
~/sources/compose 8994-convert-built-images >
I was able to use the flag alone and I was also able to pass it to an unrelated flag such as --volumes
Scenario 2 requires a lot of development @glours . For the time being, it can combine only with
|
A possible issue with my proposed solution is that No strong opinion yet on the best approach, need to think twice about it |
introduce config --images --only-built
Yep! @ndeloof , Think about |
Got it, make sense. |
Also, @ndeloof we can go agile : releasing |
3bf943e
to
accadb0
Compare
@ndeloof @glours , since adding new flag depends on
I would suggest to accept this feature as incremental release , and with motivation to go AGILE. |
I don't think we should accept this incremental step and I'll explain why I really prefer that we take few days to think to a proper solution instead of rushing. If you're currently block by this missing option, maybe piping the json output format |
I tend to agree. Agile != "let's add random stuff and change our mind any time", especially when it comes to UX. Once we introduce a new flag, it will be there forever. |
Totally agree @glours @ndeloof , this is INTERFACE design pattern & it should be stable by Design. Nevertheless, i will be waiting for the final design in #8994 , so we can go with it, and i would be happy to resume the contribution. |
It solves docker#8994 Signed-off-by: abdennour <[email protected]>
accadb0
to
6b87c11
Compare
it solves docker#8994 Signed-off-by: abdennour <[email protected]>
c4cb979
to
7020503
Compare
@ndeloof @glours i made the change as per my comment here #8994 (comment) |
Hello @abdennour Sorry for the delay of the response. |
What I did
Ability to filter images by services which uses built images
implement proposal of #8994 , exactly, option 1
Related issue
#8994
(not mandatory) A picture of a cute animal, if possible in relation with what you did