Add export command #12120
Open
Add export command #12120
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ndeloof
approved these changes
Sep 17, 2024
jarqvi
force-pushed
the
feat/export-command
branch
2 times, most recently
from
1dfa246
to
598a1dc
Compare
|
Thank u @ndeloof. |
|
not sure how you did, but better rebase on main branch, stash all your commit and amend with |
jarqvi
force-pushed
the
feat/export-command
branch
5 times, most recently
from
598a1dc
to
cb0b70a
Compare
Oh sorry, i solved this issue with a messy approach:) |
|
Is this good? |
jarqvi
force-pushed
the
feat/export-command
branch
from
cb0b70a
to
6d413d0
Compare
|
Still sign-off line missing in commit message. Maybe amend and add it manually ? |
Signed-off-by: MohammadHasan Akbari <[email protected]>
jarqvi
force-pushed
the
feat/export-command
branch
from
6d413d0
to
ab4a8da
Compare
Done. |
ndeloof
approved these changes
Sep 18, 2024
ndeloof
requested review from
a team and
jhrotko
and removed request for
a team
|
Do I have to do anything else? |
|
@jarqvi just need to fix issues reported by CI :) |
Signed-off-by: MohammadHasan Akbari <[email protected]>
Signed-off-by: MohammadHasan Akbari <[email protected]>
|
@ndeloof done =) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
I noticed that we have this command in the Docker CLI, but not in Docker Compose. So I thought of adding it to make it useful for others.