Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Global task hooks - remove case references #3

Draft
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

tobraha
Copy link

@tobraha tobraha commented Mar 28, 2023

This pull creates a new elif for global_task hooks and normalizes the data referring to a specific case as it does not exist for a global task.

I'm using the following configuration for the webhook to post to Microsoft Teams:

{   
    "instance_url": "https://iris.dev",
    "webhooks": [
        {
            "name": "Microsoft Teams",
            "active": true,
            "trigger_on": [
                "on_postload_case_create",
                "on_postload_case_delete",
                "on_postload_ioc_create",
                "on_postload_ioc_update",
                "on_postload_evidence_create",
                "on_postload_evidence_update",
                "on_postload_task_create",
                "on_postload_task_update",
                "on_postload_global_task_create",
                "on_postload_global_task_update",
                "on_postload_report_create",
                "on_postload_activities_report_create"
                ],
            "request_url": "https://my.webhook.url/stuff",
            "request_rendering": "html", 
            "request_body": {
                "title" : "%TITLE%",
                "text" : "%DESCRIPTION%"
            }
        }
    ]
}

Bump module version to 1.0.3

Resolves #2

@tobraha tobraha marked this pull request as draft April 18, 2023 15:11
@tobraha
Copy link
Author

tobraha commented Apr 18, 2023

Moved this PR to Draft as I'm adding in another minor fix for the report webhooks as well. The report hook object doesn't define some of the case data, so the data looks something like this:

image

I'm adding in something like this, but I'm still testing things out.

diff --git a/iris_webhooks_module/IrisWebHooksInterface.py b/iris_webhooks_module/IrisWebHooksInterface.py
index bf32c46..388b393 100644
--- a/iris_webhooks_module/IrisWebHooksInterface.py
+++ b/iris_webhooks_module/IrisWebHooksInterface.py
@@ -275,7 +275,9 @@ class IrisWebHooksInterface(IrisModuleInterface):
             object_url = f"{server_url}/dashboard?cid=1#gtasks_table_wrapper"

         elif hook_object == 'report':
+            user_name = data[0].user_update.name
             object_name = 'a report'
+            case_name = data[0].case.name

         if object_url:
             object_name = self._render_url(object_url, object_name, request_rendering)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

GlobalTasks object has no attribute 'case'
1 participant