Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update docs - Point to .devcontainer folder instead of the Dockerfile file #654

Merged
merged 3 commits into from
Aug 16, 2023

Conversation

samruddhikhandale
Copy link
Member

@samruddhikhandale samruddhikhandale requested a review from a team as a code owner July 10, 2023 23:08
Copy link
Member

@joshspicer joshspicer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are these supposed to be links?

@samruddhikhandale
Copy link
Member Author

Are these supposed to be links?

@joshspicer Yes, From this issue #653, looks there was a confusion as in which Dockerfile we were referencing to? Hence, linking should avoid any unwanted confusions.

Also, #653 (comment)

I kept the last sentence more general to avoid needing to link every readme uniquely, though if we're willing to do that and don't think the links will break, that'd also probably help.

@dpprdan
Copy link
Contributor

dpprdan commented Jul 12, 2023

@samruddhikhandale I think @joshspicer is refering to the link syntax, i.e. the links do not work now.

grafik

Ironically, the changes are also missing for the python image. In total I count 18 images but only 13 of their READMEs are changed here.

@samruddhikhandale
Copy link
Member Author

@samruddhikhandale I think @joshspicer is refering to the link syntax, i.e. the links do not work now.

My bad, didn't realize that. Thank you! Corrected in 80d4644

Ironically, the changes are also missing for the python image. In total I count 18 images but only 13 of their READMEs are changed here.

Updated for the python's README. For other images, surprisingly I don't see such a statement (hence, didn't modify those)

@samruddhikhandale samruddhikhandale merged commit e670bb4 into main Aug 16, 2023
15 checks passed
@samruddhikhandale samruddhikhandale deleted the samruddhikhandale/update-docs branch August 16, 2023 18:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants