Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[miniconda] Patch Python due to GHSA-5cpq-8wj7-hf2v #634

Merged
merged 12 commits into from
Jul 26, 2023
Merged

[miniconda] Patch Python due to GHSA-5cpq-8wj7-hf2v #634

merged 12 commits into from
Jul 26, 2023

Conversation

alexander-smolyakov
Copy link
Contributor

@alexander-smolyakov alexander-smolyakov commented Jun 20, 2023

Dev container name:

  • miniconda

Description:

This PR addresses the GHSA-5cpq-8wj7-hf2v vulnerability. The vulnerability comes from the continuumio/miniconda3 image and is related to the cryptography package. This image is used upstream for the miniconda dev container.

Changelog:

  • Updated Dockerfile to install the latest versions of pyopenssl and cryptography;
  • Added tests to verify the minimum version for pyopenssl and cryptography packages:
    • cryptography: Minimum package version set to 41.0.2, which fixes GHSA-5cpq-8wj7-hf2v ;
    • pyopenssl: Minimum package version set to 23.2.0 to be compatible with cryptography packages;
  • Added tests to verify minimum package version via the conda list command.

Checklist:

  • Checked that applied changes work as expected

- Update Dockerfile to install the latest versions of pyopenssl and cryptography;
- Added tests to verify minimum version for pyopenssl and cryptography packages;
- Added tests to verify minimum package version via `conda list` command.
@alexander-smolyakov alexander-smolyakov requested a review from a team as a code owner June 20, 2023 08:23
Copy link
Member

@samruddhikhandale samruddhikhandale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@samruddhikhandale samruddhikhandale merged commit 4913fb2 into devcontainers:main Jul 26, 2023
3 checks passed
@alexander-smolyakov alexander-smolyakov deleted the users/alexander-smolyakov/miniconda_GHSA-5cpq-8wj7-hf2v_bump-cryptography-version branch July 26, 2023 15:31
@samruddhikhandale samruddhikhandale mentioned this pull request Jul 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants