feat(desktop-lite): make fluxbox optional #1058

phorcys420 · 2024-07-24T14:52:34Z

This PR implements the installFluxbox parameter that allows template administrators to install another windows manager or desktop environment if they wish to do so.

#1030

phorcys420 · 2024-08-04T20:43:35Z

The tests pass.

devcontainer features test -f desktop-lite

node ➜ /workspaces/features (main) $ devcontainer features test -f desktop-lite

┌ ─ ─ ─ ─ ─ ─ ─ ─ ─ ─ ─ ─ ─ ─ ┐
|    Dev Container Features   |   
│           v0.67.0           │
└ ─ ─ ─ ─ ─ ─ ─ ─ ─ ─ ─ ─ ─ ─ ┘

>  baseImage:         ubuntu:focal
>  Target Folder:     /workspaces/features
>  features:          desktop-lite
>  workspaceFolder:   /tmp/devcontainercli/container-features-test/1722803792715

⏳ Building test container...

[1 ms] @devcontainers/cli 0.67.0. Node.js v18.20.4. linux 5.15.153.1-microsoft-standard-WSL2 x64.
[2667 ms] Resolving Feature dependencies for './desktop-lite'...
[3422 ms] Soft-dependency 'ghcr.io/devcontainers/features/common-utils' is not required.  Removing from installation order...
[3444 ms] Start: Run: docker buildx build --load --build-context dev_containers_feature_content_source=/tmp/devcontainercli-node/container-features/0.67.0-1722803795599 --build-arg _DEV_CONTAINERS_BASE_IMAGE=ubuntu:focal --build-arg _DEV_CONTAINERS_IMAGE_USER=root --build-arg _DEV_CONTAINERS_FEATURE_CONTENT_SOURCE=dev_container_feature_content_temp --target dev_containers_target_stage -f /tmp/devcontainercli-node/container-features/0.67.0-1722803795599/Dockerfile.extended -t vsc-1722803792715-8eb9833de3d552514b9688330f9620b66ead65b0e0f50b02d784de1623e76bfe-features /tmp/devcontainercli-node/empty-folder
[+] Building 72.7s (15/15) FINISHED                                                                                                                                                           docker:default
 => [internal] load build definition from Dockerfile.extended                                                                                                                                           0.0s
 => => transferring dockerfile: 1.74kB                                                                                                                                                                  0.0s
 => resolve image config for docker-image://docker.io/docker/dockerfile:1.4                                                                                                                             0.9s
 => CACHED docker-image://docker.io/docker/dockerfile:1.4@sha256:9ba7531bd80fb0a858632727cf7a112fbfd19b17e94c4e84ced81e24ef1a0dbc                                                                       0.0s
 => [internal] load .dockerignore                                                                                                                                                                       0.0s
 => => transferring context: 2B                                                                                                                                                                         0.0s
 => [context dev_containers_feature_content_source] load .dockerignore                                                                                                                                  0.0s
 => => transferring dev_containers_feature_content_source: 2B                                                                                                                                           0.0s
 => [internal] load metadata for docker.io/library/ubuntu:focal                                                                                                                                         0.7s
 => [context dev_containers_feature_content_source] load from client                                                                                                                                    0.0s
 => => transferring dev_containers_feature_content_source: 29.80kB                                                                                                                                      0.0s
 => [dev_containers_feature_content_normalize 1/3] FROM docker.io/library/ubuntu:focal@sha256:0b897358ff6624825fb50d20ffb605ab0eaea77ced0adb8c6a4b756513dec6fc                                          0.0s
 => CACHED [dev_containers_target_stage 2/5] RUN mkdir -p /tmp/dev-container-features                                                                                                                   0.0s
 => CACHED [dev_containers_feature_content_normalize 2/3] COPY --from=dev_containers_feature_content_source devcontainer-features.builtin.env /tmp/build-features/                                      0.0s
 => CACHED [dev_containers_feature_content_normalize 3/3] RUN chmod -R 0755 /tmp/build-features/                                                                                                        0.0s
 => CACHED [dev_containers_target_stage 3/5] COPY --from=dev_containers_feature_content_normalize /tmp/build-features/ /tmp/dev-container-features                                                      0.0s
 => CACHED [dev_containers_target_stage 4/5] RUN echo "_CONTAINER_USER_HOME=$( (command -v getent >/dev/null 2>&1 && getent passwd 'root' || grep -E '^root|^[^:]*:[^:]*:root:' /etc/passwd || true) |  0.0s
 => [dev_containers_target_stage 5/5] RUN --mount=type=bind,from=dev_containers_feature_content_source,source=desktop-lite_0,target=/tmp/build-features-src/desktop-lite_0     cp -ar /tmp/build-feat  68.1s
 => exporting to image                                                                                                                                                                                  2.8s 
 => => exporting layers                                                                                                                                                                                 2.8s 
 => => writing image sha256:7f5c9fae5c19aa46a981850e8a1557e1b6a188928ee9f222b23e95d96b4f7e50                                                                                                            0.0s 
 => => naming to docker.io/library/vsc-1722803792715-8eb9833de3d552514b9688330f9620b66ead65b0e0f50b02d784de1623e76bfe-features                                                                          0.0s 
[76332 ms] Start: Run: docker run --sig-proxy=false -a STDOUT -a STDERR --mount type=bind,source=/tmp/devcontainercli/container-features-test/1722803792715,target=/workspaces/1722803792715 -l devcontainer.local_folder=/tmp/devcontainercli/container-features-test/1722803792715 -l devcontainer.is_test_run=true --init --entrypoint /bin/sh vsc-1722803792715-8eb9833de3d552514b9688330f9620b66ead65b0e0f50b02d784de1623e76bfe-features -c echo Container started
Container started

🚀 Launched container.
>  containerId:          0ceccf2aa506f74fe4fdb062adaa43551019d7265371474a021b459cd1a2ca49

🏃 Starting test(s)...

🧪 Starting 'desktop-lite' tests...


🔄 Testing 'desktop-init-exists'

/usr/local/share/desktop-init.sh


✅  Passed 'desktop-init-exists'!


🔄 Testing 'log-exists'

/tmp/container-init.log


✅  Passed 'log-exists'!

🧪 Testing if libasound2 exists !
✅  Package 'libasound2' is installed.
🧪 Executing scenarios for feature 'desktop-lite'...
>  Running scenario:  with_fluxbox

📝 Scenario generated: {
  "image": "mcr.microsoft.com/devcontainers/base:ubuntu-20.04",
  "features": {
    "./desktop-lite": {
      "installFluxbox": true
    }
  }
}
>  workspaceFolder:   /tmp/devcontainercli/container-features-test/1722803870102

⏳ Building test container...

[0 ms] @devcontainers/cli 0.67.0. Node.js v18.20.4. linux 5.15.153.1-microsoft-standard-WSL2 x64.
[1200 ms] Resolving Feature dependencies for './desktop-lite'...
[1942 ms] Soft-dependency 'ghcr.io/devcontainers/features/common-utils' is not required.  Removing from installation order...
[1946 ms] Start: Run: docker buildx build --load --build-context dev_containers_feature_content_source=/tmp/devcontainercli-node/container-features/0.67.0-1722803871362 --build-arg _DEV_CONTAINERS_BASE_IMAGE=mcr.microsoft.com/devcontainers/base:ubuntu-20.04 --build-arg _DEV_CONTAINERS_IMAGE_USER=root --build-arg _DEV_CONTAINERS_FEATURE_CONTENT_SOURCE=dev_container_feature_content_temp --target dev_containers_target_stage -f /tmp/devcontainercli-node/container-features/0.67.0-1722803871362/Dockerfile.extended -t vsc-1722803870102-f0cdbfcd6cf2c3398efba9ebe2e894158fd55cfd99df126e49312510ad3889fc-features /tmp/devcontainercli-node/empty-folder
[+] Building 72.2s (15/15) FINISHED                                                                                                                                                           docker:default
 => [internal] load build definition from Dockerfile.extended                                                                                                                                           0.0s
 => => transferring dockerfile: 1.90kB                                                                                                                                                                  0.0s
 => resolve image config for docker-image://docker.io/docker/dockerfile:1.4                                                                                                                             0.5s
 => CACHED docker-image://docker.io/docker/dockerfile:1.4@sha256:9ba7531bd80fb0a858632727cf7a112fbfd19b17e94c4e84ced81e24ef1a0dbc                                                                       0.0s
 => [internal] load .dockerignore                                                                                                                                                                       0.0s
 => => transferring context: 2B                                                                                                                                                                         0.0s
 => [internal] load metadata for mcr.microsoft.com/devcontainers/base:ubuntu-20.04                                                                                                                      0.4s
 => [context dev_containers_feature_content_source] load .dockerignore                                                                                                                                  0.0s
 => => transferring dev_containers_feature_content_source: 2B                                                                                                                                           0.0s
 => [dev_containers_feature_content_normalize 1/3] FROM mcr.microsoft.com/devcontainers/base:ubuntu-20.04@sha256:57b6ba5c175eb56cf3fd9b4dff6a232bfbddf476d61906638e7a2de1b29cf2ca                       9.6s
 => => resolve mcr.microsoft.com/devcontainers/base:ubuntu-20.04@sha256:57b6ba5c175eb56cf3fd9b4dff6a232bfbddf476d61906638e7a2de1b29cf2ca                                                                0.0s
 => => sha256:d3e3e3e2fb77bf93d1ab7c5b1f1369aed1c07051bb099de874618edb9ba2c167 1.81kB / 1.81kB                                                                                                          0.0s
 => => sha256:cb3c931c69a27b5f54734e93bb23b91a5063b3384e382d633351629f12aced5a 409B / 409B                                                                                                              0.3s
 => => sha256:57b6ba5c175eb56cf3fd9b4dff6a232bfbddf476d61906638e7a2de1b29cf2ca 856B / 856B                                                                                                              0.0s
 => => sha256:c0f0b693a55ba8f2f62faf455314042339a92e3d947e131e8a5a9f4763a1be17 11.13MB / 11.13MB                                                                                                        0.5s
 => => sha256:3263725015be4de2591178f778a1e52b9527e1c59b2f56196e8ad4747a77ac55 132B / 132B                                                                                                              0.4s
 => => sha256:f114a02cd5268539d9aa7a07975c1fb0af68117cf1983514f9f721a9f73f09f0 9.66kB / 9.66kB                                                                                                          0.0s
 => => sha256:bc60c74f4be0501b9fd5ca6be83c6e13af064b47e81efb9ee51c747cfe7350f3 223B / 223B                                                                                                              0.5s
 => => sha256:1e6f4b81b8ef6a2c5890c15a18bb3bb2b18868b0a25662ea3866281a205b62cf 233B / 233B                                                                                                              0.6s
 => => extracting sha256:c0f0b693a55ba8f2f62faf455314042339a92e3d947e131e8a5a9f4763a1be17                                                                                                               0.9s
 => => sha256:90479f68baa793311ecf804d31de39ba114fe189544ad0f138f870c5019dc7c6 135.42MB / 135.42MB                                                                                                      4.2s
 => => sha256:fb7249cfd55204bb9227a4e63bc612d4263c4982fbbc05ddefaa775b2c71e789 87.02MB / 87.02MB                                                                                                        3.4s
 => => extracting sha256:cb3c931c69a27b5f54734e93bb23b91a5063b3384e382d633351629f12aced5a                                                                                                               0.0s
 => => extracting sha256:3263725015be4de2591178f778a1e52b9527e1c59b2f56196e8ad4747a77ac55                                                                                                               0.0s
 => => extracting sha256:bc60c74f4be0501b9fd5ca6be83c6e13af064b47e81efb9ee51c747cfe7350f3                                                                                                               0.0s
 => => extracting sha256:1e6f4b81b8ef6a2c5890c15a18bb3bb2b18868b0a25662ea3866281a205b62cf                                                                                                               0.0s
 => => extracting sha256:fb7249cfd55204bb9227a4e63bc612d4263c4982fbbc05ddefaa775b2c71e789                                                                                                               3.6s
 => => extracting sha256:90479f68baa793311ecf804d31de39ba114fe189544ad0f138f870c5019dc7c6                                                                                                               2.3s
 => [context dev_containers_feature_content_source] load from client                                                                                                                                    0.0s
 => => transferring dev_containers_feature_content_source: 29.96kB                                                                                                                                      0.0s
 => [dev_containers_feature_content_normalize 2/3] COPY --from=dev_containers_feature_content_source devcontainer-features.builtin.env /tmp/build-features/                                             0.6s
 => [dev_containers_target_stage 2/5] RUN mkdir -p /tmp/dev-container-features                                                                                                                          0.6s
 => [dev_containers_feature_content_normalize 3/3] RUN chmod -R 0755 /tmp/build-features/                                                                                                               0.5s
 => [dev_containers_target_stage 3/5] COPY --from=dev_containers_feature_content_normalize /tmp/build-features/ /tmp/dev-container-features                                                             0.0s
 => [dev_containers_target_stage 4/5] RUN echo "_CONTAINER_USER_HOME=$( (command -v getent >/dev/null 2>&1 && getent passwd 'root' || grep -E '^root|^[^:]*:[^:]*:root:' /etc/passwd || true) | cut -d  0.5s
 => [dev_containers_target_stage 5/5] RUN --mount=type=bind,from=dev_containers_feature_content_source,source=desktop-lite_0,target=/tmp/build-features-src/desktop-lite_0     cp -ar /tmp/build-feat  57.8s
 => exporting to image                                                                                                                                                                                  2.1s
 => => exporting layers                                                                                                                                                                                 2.1s
 => => writing image sha256:d894f9839eaa6a0dc97a306505ae7ddf8bd26d66b7e038cbdf6db016e017c8a1                                                                                                            0.0s
 => => naming to docker.io/library/vsc-1722803870102-f0cdbfcd6cf2c3398efba9ebe2e894158fd55cfd99df126e49312510ad3889fc-features                                                                          0.0s
[+] Building 0.4s (6/6) FINISHED                                                                                                                                                              docker:default
 => [internal] load build definition from updateUID.Dockerfile-0.67.0                                                                                                                                   0.0s
 => => transferring dockerfile: 1.52kB                                                                                                                                                                  0.0s
 => [internal] load metadata for docker.io/library/vsc-1722803870102-f0cdbfcd6cf2c3398efba9ebe2e894158fd55cfd99df126e49312510ad3889fc-features:latest                                                   0.0s
 => [internal] load .dockerignore                                                                                                                                                                       0.0s
 => => transferring context: 2B                                                                                                                                                                         0.0s
 => [1/2] FROM docker.io/library/vsc-1722803870102-f0cdbfcd6cf2c3398efba9ebe2e894158fd55cfd99df126e49312510ad3889fc-features:latest                                                                     0.1s
 => [2/2] RUN eval $(sed -n "s/vscode:[^:]*:\([^:]*\):\([^:]*\):[^:]*:\([^:]*\).*/OLD_UID=\1;OLD_GID=\2;HOME_FOLDER=\3/p" /etc/passwd);  eval $(sed -n "s/\([^:]*\):[^:]*:1000:.*/EXISTING_USER=\1/p"   0.3s
 => exporting to image                                                                                                                                                                                  0.0s
 => => exporting layers                                                                                                                                                                                 0.0s
 => => writing image sha256:ff5819bf620047b733a62e0f3c9fa42504efe0bffe5537b22b4397f873a485d3                                                                                                            0.0s
 => => naming to docker.io/library/vsc-1722803870102-f0cdbfcd6cf2c3398efba9ebe2e894158fd55cfd99df126e49312510ad3889fc-features-uid                                                                      0.0s
[74755 ms] Start: Run: docker run --sig-proxy=false -a STDOUT -a STDERR --mount type=bind,source=/tmp/devcontainercli/container-features-test/1722803870102,target=/workspaces/1722803870102 -l devcontainer.local_folder=/tmp/devcontainercli/container-features-test/1722803870102 -l devcontainer.is_test_run=true --init --entrypoint /bin/sh vsc-1722803870102-f0cdbfcd6cf2c3398efba9ebe2e894158fd55cfd99df126e49312510ad3889fc-features-uid -c echo Container started
Container started

🚀 Launched container.
>  containerId:          95063aeecc8c3566ad71c708387cdc30dd6dd5859ee3fbc210b44687600baf5c


🔄 Testing 'fluxbox exists'

total 44
drwxr-xr-x 1 vscode root   4096 Aug  4 20:39 .
drwxr-xr-x 1 vscode vscode 4096 Aug  4 20:39 ..
-rw-r--r-- 1 vscode root     99 Aug  4 20:39 apps
-rw-r--r-- 1 vscode root    410 Aug  4 20:39 init
-rw-rw-r-- 1 vscode vscode 3713 Aug  4 20:39 keys
-rw-rw-r-- 1 vscode vscode   52 Aug  4 20:39 lastwallpaper
-rw-r--r-- 1 vscode root    880 Aug  4 20:39 menu
-rw-rw-r-- 1 vscode vscode   89 Aug  4 20:39 overlay
-rw-r--r-- 1 vscode vscode  743 Aug  4 20:39 startup
-rw-rw-r-- 1 vscode vscode  168 Aug  4 20:39 windowmenu


✅  Passed 'fluxbox exists'!
>  Running scenario:  without_fluxbox

📝 Scenario generated: {
  "image": "mcr.microsoft.com/devcontainers/base:ubuntu-20.04",
  "features": {
    "./desktop-lite": {
      "installFluxbox": false
    }
  }
}
>  workspaceFolder:   /tmp/devcontainercli/container-features-test/1722803945720

⏳ Building test container...

[0 ms] @devcontainers/cli 0.67.0. Node.js v18.20.4. linux 5.15.153.1-microsoft-standard-WSL2 x64.
[1108 ms] Resolving Feature dependencies for './desktop-lite'...
[1885 ms] Soft-dependency 'ghcr.io/devcontainers/features/common-utils' is not required.  Removing from installation order...
[1889 ms] Start: Run: docker buildx build --load --build-context dev_containers_feature_content_source=/tmp/devcontainercli-node/container-features/0.67.0-1722803946889 --build-arg _DEV_CONTAINERS_BASE_IMAGE=mcr.microsoft.com/devcontainers/base:ubuntu-20.04 --build-arg _DEV_CONTAINERS_IMAGE_USER=root --build-arg _DEV_CONTAINERS_FEATURE_CONTENT_SOURCE=dev_container_feature_content_temp --target dev_containers_target_stage -f /tmp/devcontainercli-node/container-features/0.67.0-1722803946889/Dockerfile.extended -t vsc-1722803945720-d7e76f105c80d26a1ef468214ee1ba97d782e9c32271c74c5558c80eb90b44cc-features /tmp/devcontainercli-node/empty-folder
[+] Building 61.9s (15/15) FINISHED                                                                                                                                                           docker:default
 => [internal] load build definition from Dockerfile.extended                                                                                                                                           0.0s
 => => transferring dockerfile: 1.90kB                                                                                                                                                                  0.0s
 => resolve image config for docker-image://docker.io/docker/dockerfile:1.4                                                                                                                             0.5s
 => CACHED docker-image://docker.io/docker/dockerfile:1.4@sha256:9ba7531bd80fb0a858632727cf7a112fbfd19b17e94c4e84ced81e24ef1a0dbc                                                                       0.0s
 => [internal] load .dockerignore                                                                                                                                                                       0.0s
 => => transferring context: 2B                                                                                                                                                                         0.0s
 => [internal] load metadata for mcr.microsoft.com/devcontainers/base:ubuntu-20.04                                                                                                                      0.1s
 => [context dev_containers_feature_content_source] load .dockerignore                                                                                                                                  0.0s
 => => transferring dev_containers_feature_content_source: 2B                                                                                                                                           0.0s
 => [context dev_containers_feature_content_source] load from client                                                                                                                                    0.0s
 => => transferring dev_containers_feature_content_source: 29.96kB                                                                                                                                      0.0s
 => [dev_containers_feature_content_normalize 1/3] FROM mcr.microsoft.com/devcontainers/base:ubuntu-20.04@sha256:57b6ba5c175eb56cf3fd9b4dff6a232bfbddf476d61906638e7a2de1b29cf2ca                       0.0s
 => CACHED [dev_containers_target_stage 2/5] RUN mkdir -p /tmp/dev-container-features                                                                                                                   0.0s
 => CACHED [dev_containers_feature_content_normalize 2/3] COPY --from=dev_containers_feature_content_source devcontainer-features.builtin.env /tmp/build-features/                                      0.0s
 => CACHED [dev_containers_feature_content_normalize 3/3] RUN chmod -R 0755 /tmp/build-features/                                                                                                        0.0s
 => CACHED [dev_containers_target_stage 3/5] COPY --from=dev_containers_feature_content_normalize /tmp/build-features/ /tmp/dev-container-features                                                      0.0s
 => CACHED [dev_containers_target_stage 4/5] RUN echo "_CONTAINER_USER_HOME=$( (command -v getent >/dev/null 2>&1 && getent passwd 'root' || grep -E '^root|^[^:]*:[^:]*:root:' /etc/passwd || true) |  0.0s
 => [dev_containers_target_stage 5/5] RUN --mount=type=bind,from=dev_containers_feature_content_source,source=desktop-lite_0,target=/tmp/build-features-src/desktop-lite_0     cp -ar /tmp/build-feat  59.0s
 => exporting to image                                                                                                                                                                                  2.1s 
 => => exporting layers                                                                                                                                                                                 2.1s 
 => => writing image sha256:b5032e3502a2c382d63c752031cbfce95be29b87ba1f560389223cb97ea6e23e                                                                                                            0.0s 
 => => naming to docker.io/library/vsc-1722803945720-d7e76f105c80d26a1ef468214ee1ba97d782e9c32271c74c5558c80eb90b44cc-features                                                                          0.0s 
[+] Building 0.4s (6/6) FINISHED                                                                                                                                                              docker:default 
 => [internal] load build definition from updateUID.Dockerfile-0.67.0                                                                                                                                   0.0s 
 => => transferring dockerfile: 1.52kB                                                                                                                                                                  0.0s
 => [internal] load metadata for docker.io/library/vsc-1722803945720-d7e76f105c80d26a1ef468214ee1ba97d782e9c32271c74c5558c80eb90b44cc-features:latest                                                   0.0s
 => [internal] load .dockerignore                                                                                                                                                                       0.0s
 => => transferring context: 2B                                                                                                                                                                         0.0s
 => [1/2] FROM docker.io/library/vsc-1722803945720-d7e76f105c80d26a1ef468214ee1ba97d782e9c32271c74c5558c80eb90b44cc-features:latest                                                                     0.0s
 => [2/2] RUN eval $(sed -n "s/vscode:[^:]*:\([^:]*\):\([^:]*\):[^:]*:\([^:]*\).*/OLD_UID=\1;OLD_GID=\2;HOME_FOLDER=\3/p" /etc/passwd);  eval $(sed -n "s/\([^:]*\):[^:]*:1000:.*/EXISTING_USER=\1/p"   0.3s
 => exporting to image                                                                                                                                                                                  0.0s
 => => exporting layers                                                                                                                                                                                 0.0s
 => => writing image sha256:8209880f13c81514d4215db38bc2611b1ec4b50686d00e8b4dd94992c96ff2d1                                                                                                            0.0s
 => => naming to docker.io/library/vsc-1722803945720-d7e76f105c80d26a1ef468214ee1ba97d782e9c32271c74c5558c80eb90b44cc-features-uid                                                                      0.0s
[64449 ms] Start: Run: docker run --sig-proxy=false -a STDOUT -a STDERR --mount type=bind,source=/tmp/devcontainercli/container-features-test/1722803945720,target=/workspaces/1722803945720 -l devcontainer.local_folder=/tmp/devcontainercli/container-features-test/1722803945720 -l devcontainer.is_test_run=true --init --entrypoint /bin/sh vsc-1722803945720-d7e76f105c80d26a1ef468214ee1ba97d782e9c32271c74c5558c80eb90b44cc-features-uid -c echo Container started
Container started

🚀 Launched container.
>  containerId:          edbfac644c28d5310359b9b4d5531deade7a015c8a396ee57c81868750783d63


🔄 Testing 'fluxbox does not exist'

ls: cannot access '/home/vscode/.fluxbox': No such file or directory


✅  Passed 'fluxbox does not exist'!
🧪 Executing duplicate test for feature 'desktop-lite'...
⚠️ Skipping duplicate test for desktop-lite because '/workspaces/features/test/desktop-lite/duplicate.sh' does not exist.
🧹 Cleaning up 3 test containers...
🧹 Removing container edbfac644c28...
🧹 Removing container 95063aeecc8c...
🧹 Removing container 0ceccf2aa506...



  ================== TEST REPORT ==================
✅ Passed:      'desktop-lite'
✅ Passed:      'with_fluxbox'
✅ Passed:      'without_fluxbox'

samruddhikhandale

Overall looks great, left some minor comments.

src/desktop-lite/install.sh

test/desktop-lite/test.sh

src/desktop-lite/NOTES.md

Co-authored-by: Samruddhi Khandale <[email protected]>

samruddhikhandale

Looks great, thanks!

src/desktop-lite/devcontainer-feature.json

samruddhikhandale

Thank you!

samruddhikhandale · 2024-08-14T16:46:06Z

src/desktop-lite/install.sh

@@ -197,7 +198,12 @@ else
    package_list="${package_list} tilix"
 fi

-# Install X11, fluxbox and VS Code dependencies
+# If we want to install Fluxbox, then add it to the list of pacakges


Suggested change

# If we want to install Fluxbox, then add it to the list of pacakges

# If we want to install Fluxbox, then add it to the list of packages

phorcys420 added 3 commits July 24, 2024 13:04

feat(desktop-lite): make fluxbox optional

9942b51

Merge branch 'devcontainers:main' into desktop-lite-no-fluxbox

a0b637a

feat(desktop-lite): add test scenarios

e7d45de

phorcys420 marked this pull request as ready for review August 9, 2024 20:13

phorcys420 requested a review from a team as a code owner August 9, 2024 20:13

samruddhikhandale requested changes Aug 13, 2024

View reviewed changes

src/desktop-lite/install.sh Outdated Show resolved Hide resolved

src/desktop-lite/install.sh Show resolved Hide resolved

test/desktop-lite/test.sh Show resolved Hide resolved

src/desktop-lite/NOTES.md Outdated Show resolved Hide resolved

phorcys420 and others added 4 commits August 13, 2024 22:51

chore: remove space in install.sh

657c7cf

Co-authored-by: Samruddhi Khandale <[email protected]>

chore: clarify README.md

1c50d70

Co-authored-by: Samruddhi Khandale <[email protected]>

chore: fix incorrect capitalization in NOTES.md

3d1e9fd

Merge branch 'main' into desktop-lite-no-fluxbox

08150ac

phorcys420 requested a review from samruddhikhandale August 13, 2024 20:53

samruddhikhandale previously approved these changes Aug 13, 2024

View reviewed changes

samruddhikhandale reviewed Aug 13, 2024

View reviewed changes

src/desktop-lite/devcontainer-feature.json Show resolved Hide resolved

chore: bump desktop-lite version to 1.2.4

eff89e7

phorcys420 dismissed samruddhikhandale’s stale review via eff89e7 August 14, 2024 10:01

phorcys420 requested a review from samruddhikhandale August 14, 2024 10:02

samruddhikhandale approved these changes Aug 14, 2024

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(desktop-lite): make fluxbox optional #1058

feat(desktop-lite): make fluxbox optional #1058

phorcys420 commented Jul 24, 2024

phorcys420 commented Aug 4, 2024

samruddhikhandale left a comment

samruddhikhandale left a comment

samruddhikhandale left a comment

samruddhikhandale Aug 14, 2024

	# If we want to install Fluxbox, then add it to the list of pacakges
	# If we want to install Fluxbox, then add it to the list of packages

feat(desktop-lite): make fluxbox optional #1058

Are you sure you want to change the base?

feat(desktop-lite): make fluxbox optional #1058

Conversation

phorcys420 commented Jul 24, 2024

phorcys420 commented Aug 4, 2024

samruddhikhandale left a comment

Choose a reason for hiding this comment

samruddhikhandale left a comment

Choose a reason for hiding this comment

samruddhikhandale left a comment

Choose a reason for hiding this comment

samruddhikhandale Aug 14, 2024

Choose a reason for hiding this comment