Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update github-actions[bot]'s email address #70

Closed
wants to merge 1 commit into from

Conversation

eitsupi
Copy link
Contributor

@eitsupi eitsupi commented Sep 3, 2023

Perhaps the bot's email address is incorrect and not correctly identified as a GitHub Actions one by GitHub?

image
From https://github.com/rocker-org/devcontainer-features/graphs/contributors

@@ -31,7 +31,7 @@ jobs:
set -e
echo "Start."
# Configure git and Push updates
git config --global user.email github-actions[bot]@users.noreply.github.com
git config --global user.email 41898282+github-actions[bot]@users.noreply.github.com
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Curious, why do we need to append the numbers?

From actions/checkout#479, the current address seems correct to me. For a while until #64 was merged, I agree there were commits from 'Invalid user'. I wonder if that's something the stats are showing?

Also, all the recent commit (doc updates), looks good to me. See https://github.com/rocker-org/devcontainer-features/commits/main

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, I see. #64 seems fixing that. Thanks!

@eitsupi eitsupi closed this Sep 6, 2023
@eitsupi eitsupi deleted the patch-1 branch September 6, 2023 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants