Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update collection-index.yml #446

Open
wants to merge 1 commit into
base: gh-pages
Choose a base branch
from

Conversation

igwejk
Copy link

@igwejk igwejk commented Aug 9, 2024

List demos-by-igwejk/devcontainer-templates/java template

What type of PR is this?

  • Add a new dev container collection
  • Update to an existing dev container collection
  • Documentation/spec update
  • Other containers.dev site update (UX, layout, etc)

Related Issues

  • Related Issue #
  • Closes #

Description

Please replace this line with a description of your PR.

Collection checklist

If your PR contributes a new collection, please utilize this checklist:

  • Collection name
  • Maintainer name
  • Maintainer contact link (i.e. link to a GitHub repo, email)
  • Repository URL
  • OCI Reference
  • I acknowledge that this collection provides new functionality, distinct from the existing collections part of this index.

List demos-by-igwejk/devcontainer-templates/java template
@igwejk igwejk requested a review from a team as a code owner August 9, 2024 10:48
maintainer: igwejk
contact: https://github.com/demos-by-igwejk/devcontainer-templates/issues
repository: https://github.com/demos-by-igwejk/devcontainer-templates
ociReference: ghcr.io/demos-by-igwejk/devcontainer-templates/java
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
ociReference: ghcr.io/demos-by-igwejk/devcontainer-templates/java
ociReference: ghcr.io/demos-by-igwejk/devcontainer-templates

Hi 👋

The ociReference here refers to the collection metadata artifact instead of the individual
templates. Hence, the author needs to only add a single entry irrespective of the number of Templates that might exist in their repository.

Can you help update this? thanks!

maintainer: igwejk
contact: https://github.com/demos-by-igwejk/devcontainer-templates/issues
repository: https://github.com/demos-by-igwejk/devcontainer-templates
ociReference: ghcr.io/demos-by-igwejk/devcontainer-templates/java
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you help change the visibility of this "metadata" package (and your Template package) to public? The index won't be able to crawl the Templates in demos-by-igwejk/devcontainer-templates if it's private.

Feel free to look at https://containers.dev/guide/author-a-feature#publishing for information.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants