Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

obtuse and confusing error with local feature under WSL #834 #838

Merged

Conversation

prathameshzarkar9
Copy link
Contributor

@prathameshzarkar9 prathameshzarkar9 commented Jun 5, 2024

Issue 834
Confusing error message modified to more understandable message.

Copy link
Contributor

@chrmarti chrmarti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR, left a comment.

src/spec-configuration/containerFeaturesConfiguration.ts Outdated Show resolved Hide resolved
@prathameshzarkar9
Copy link
Contributor Author

Hi @samruddhikhandale ,
I have addressed review comments and also modified the error message as suggested by @chrmarti .
Kindly review and approve the same.

src/spec-configuration/containerFeaturesConfiguration.ts Outdated Show resolved Hide resolved
src/spec-configuration/containerFeaturesConfiguration.ts Outdated Show resolved Hide resolved
src/spec-configuration/containerFeaturesConfiguration.ts Outdated Show resolved Hide resolved
src/test/cli.build.test.ts Show resolved Hide resolved
src/test/cli.build.test.ts Show resolved Hide resolved
Copy link
Member

@samruddhikhandale samruddhikhandale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, let's wait for another set of review from @chrmarti

thanks!

Copy link
Contributor

@chrmarti chrmarti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@chrmarti chrmarti merged commit 58e0a47 into devcontainers:main Jun 13, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants