Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(waiting): add error handling for errors while waiting #772

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

DomiR
Copy link

@DomiR DomiR commented May 6, 2020

While using a custom cert pinnner calling completion(.failed(error)) will update the state with state waiting passing the cert error.

In this case we also should call the error handler.

@DomiR
Copy link
Author

DomiR commented Jun 19, 2020

What do you think about this?

@daltoniam
Copy link
Owner

Makes sense, I like it. Going to cut another version (to fix some bugs) before merging this since it is a breaking changing with the enum case change. Thanks for the PR!

* upstream/master:
  4.0.4 release
  move deployment target to iOS 9 to fix compile for archive with Xcode 12
  Conditionally include 'swift-nio-zlib-support' dependency to avoid warning on macOS
  Fix compile error on Xcode 12
  Switch SPM to use Swift 5.2
  improve conditions for calling readLoop()
  Fix error when trying to convert text message partial payload to UTF-8
  In FoundationTransport deinit, remove self as a delegate to InputStream and OutputStream to prevent EXC_BAD_ACCESS
  Update README.md
  Fix deprecation warning in WSCompression
  Fix the deadlock issue on iOS 11
@scoreyou
Copy link

scoreyou commented Oct 5, 2023

@daltoniam Are there any updates on this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants