Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix annotation when a table_name_prefix is in use #1003

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

clottman
Copy link

Expected behavior:

If a table has a table name prefix, I can annotate it.

Current behavior:

Annotation fails because it's trying to use the unprefixed table name when getting the indexes.

Fix explanation

In retrieve_indexes_from_table, klass.table_name already contains the prefix if one exists. So, we shouldn't need to check separately for the prefixed or unprefixed version.

Tests

I tried to add tests; there is one failing and I'm not sure what the expected behavior is there/how to fix it. (Unclear to me if it's a test-specific failure or the fix I am suggesting doesn't work for this particular case).

Related issues

Seems related possibly to #967 and this comment - we were seeing the same error message as that user.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants