Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: replace keyring module to zondax's fork #12938

Closed
wants to merge 3 commits into from

Conversation

raynaudoe
Copy link
Contributor

@raynaudoe raynaudoe commented Aug 16, 2022

Description

Closes: #10220


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests // Not applicable
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code // Not applicable
  • updated the relevant documentation or specification // Not applicable
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@raynaudoe raynaudoe marked this pull request as ready for review August 16, 2022 21:21
@raynaudoe raynaudoe requested a review from a team as a code owner August 16, 2022 21:21
@codecov
Copy link

codecov bot commented Aug 16, 2022

Codecov Report

Merging #12938 (0fab121) into main (4fe7797) will decrease coverage by 0.16%.
The diff coverage is 85.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #12938      +/-   ##
==========================================
- Coverage   55.87%   55.71%   -0.17%     
==========================================
  Files         646      646              
  Lines       54895    54861      -34     
==========================================
- Hits        30675    30564     -111     
- Misses      21762    21844      +82     
+ Partials     2458     2453       -5     
Impacted Files Coverage Δ
x/distribution/keeper/params.go 75.00% <ø> (-3.58%) ⬇️
x/distribution/module.go 64.28% <ø> (ø)
types/dec_coin.go 98.41% <50.00%> (-0.79%) ⬇️
crypto/keyring/keyring.go 61.95% <100.00%> (ø)
x/distribution/abci.go 100.00% <100.00%> (ø)
x/distribution/keeper/allocation.go 97.10% <100.00%> (+10.43%) ⬆️
x/staking/simulation/operations.go 76.08% <100.00%> (+0.33%) ⬆️
x/genutil/gentx.go 0.00% <0.00%> (-85.49%) ⬇️
x/genutil/module.go 9.52% <0.00%> (-57.15%) ⬇️
x/genutil/genesis.go 0.00% <0.00%> (-40.00%) ⬇️
... and 5 more

@julienrbrt
Copy link
Member

Just curious, are we going to keep using zondax's fork or these changes will be upstreamed in 99designs/keyring?
If the former, shall we not then replace the imports directly instead of using replace?
If the latter, can we have a tracking issue to remove the replace eventually?

@alexanderbez alexanderbez added the backport/0.46.x PR scheduled for inclusion in the v0.46's next stable release label Aug 17, 2022
@alexanderbez
Copy link
Contributor

Should we also backport this to 0.45 @marbar3778 @AmauryM?

@raynaudoe
Copy link
Contributor Author

According to what I talked with Marko, would be better to update the cosmos' fork of 99desings/keyring and use that one instead of Zondax's one. I'll close this PR and open a new one with an updated and fixed version of https://github.com/cosmos/keyring

@raynaudoe raynaudoe closed this Aug 17, 2022
@alexanderbez alexanderbez deleted the eze/replace_keyring_module branch August 17, 2022 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport/0.46.x PR scheduled for inclusion in the v0.46's next stable release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Confusing error message when migration via keys list on macos
3 participants