Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SignalBuy contract #197

Open
wants to merge 43 commits into
base: v5
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
43 commits
Select commit Hold shift + click to select a range
a3a34d7
Copy ILimitOrder -> IPionexContract
NIC619 May 17, 2023
0b1d587
Add makerTokenAmount to IPionex TraderParam
NIC619 May 17, 2023
e34635e
Copy LimitOrderLibEIP712 -> PionexContractLibEIP712
NIC619 May 17, 2023
59b0342
Add makerTokenAmount to Fill
NIC619 May 17, 2023
fc1e0cc
Copy LimitOrder -> PionexContract
NIC619 May 17, 2023
1f8b067
Check takerToken/makerToken ratio in fillLimitOrderByTrader
NIC619 May 17, 2023
3f7978a
Copy LimitOrder tests -> PionexContract tests
NIC619 May 17, 2023
23d32d2
Adjust tests
NIC619 May 17, 2023
a575739
Change to quote from maker token instead
NIC619 May 18, 2023
ca57e62
Add better/worse takerToken/makerToken ratio tests
NIC619 May 18, 2023
c53f662
Lint
NIC619 May 18, 2023
7da8bba
Skip takerTokenAmount in quoteOrder
NIC619 May 19, 2023
dfbec2a
Remove signing test
NIC619 May 19, 2023
f8b2d26
Remove fillLimitOrderByProtocol from PionexContract
NIC619 May 19, 2023
edd0382
Remove takerFeeFactor
NIC619 May 23, 2023
a95f407
Remove profitFeeFactor
NIC619 May 23, 2023
b0e4941
Add Pionex fee factors: gas fee and strategy fee
NIC619 May 23, 2023
17c4420
Rename user to pionex in tests
NIC619 May 23, 2023
d0781c8
Update comment for fee and balance change check
NIC619 May 23, 2023
928094c
Rename maker -> user; taker -> pionex
NIC619 May 25, 2023
4429fb1
Rename
NIC619 May 26, 2023
a37116d
Rename userFeeFactor -> tokenlonFeeFactor
NIC619 May 26, 2023
1a1093d
Rename
NIC619 May 26, 2023
3667792
Merge branch 'v5' into Pionex_contract
NIC619 May 26, 2023
e5f5046
Update after merge
NIC619 May 26, 2023
1a4bf65
Remove TraderSettlement.pionex param
NIC619 May 29, 2023
b1e9d4b
Rename Maker -> User
NIC619 May 29, 2023
273d472
Add minPionexTokenAmount check to protect user
NIC619 Jun 9, 2023
ed48d9b
Remove ratio check bc we check minPionexTokenAmount
NIC619 Jun 12, 2023
f92de42
Rename pionex -> dealer
NIC619 Jun 12, 2023
8bb9f0f
Rename Pionex -> SignalBuy
NIC619 Jun 12, 2023
471fbd8
Rename LimitOrder -> SignalBuy
NIC619 Jun 12, 2023
c7cb516
Turn SignalBuy into a standalone contract
NIC619 Jun 13, 2023
91938e2
Remove unused
NIC619 Jun 14, 2023
3323a1a
Handle ETH/WETH dealer token conversion for dealer
NIC619 Jun 15, 2023
bc2bf46
Add ETH/WETH settlement tests
NIC619 Jun 15, 2023
f8612ac
Fix ORDER_TYPEHASH
NIC619 Jul 7, 2023
9f777cc
Merge remote-tracking branch 'origin/v5' into Pionex_contract
charlesjhongc Aug 14, 2023
d3ce5d9
refactor SignalBuyContract 712 lib
charlesjhongc Aug 14, 2023
2cd05c2
fix solidity lint
charlesjhongc Aug 14, 2023
a014442
fix IWETH import path
charlesjhongc Aug 16, 2023
b4082ca
fix allowFill seen check
charlesjhongc Sep 11, 2023
0951616
fix replay sig tests and import style
charlesjhongc Sep 11, 2023
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Loading
Loading