KSQL-12194, KSQL-12195 | Classify MissingSchemaException and RecordTooLargeException as user errors. #10361
+216
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pbadani
changed the title
… too large exceptions as user errors.
pbadani
force-pushed
the
pbadani/KSQL-12194-KSQL-12194
branch
from
9b93fd1
to
d754960
Compare
pbadani
changed the title
| @@ -46,8 +46,10 @@ public final class SchemaRegistryUtil { | |||
|
|
|||
| @VisibleForTesting | |||
| public static final int SUBJECT_NOT_FOUND_ERROR_CODE = 40401; | |||
| public static final int SCHEMA_NOT_FOUND_ERROR_CODE = 40403; | |||
There was a problem hiding this comment.
Curious question how was the code 40403 determined?
There was a problem hiding this comment.
The error codes are from the SR code repo
VedarthConfluent
approved these changes
Jul 5, 2024
| @@ -131,7 +131,7 @@ | |||
| <wiremock.version>2.24.0</wiremock.version> | |||
| <clearspring-analytics.version>2.9.5</clearspring-analytics.version> | |||
| <icu.version>67.1</icu.version> | |||
| <vertx.version>4.4.6</vertx.version> | |||
| <vertx.version>4.4.8</vertx.version> | |||
There was a problem hiding this comment.
Why is this change required?
There was a problem hiding this comment.
that is a mistake, I will revert it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Classify MissingSchemaException and RecordTooLargeException as user errors.
Testing done
Describe the testing strategy. Unit and integration tests are expected for any behavior changes.
Reviewer checklist