Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

5.15.13 #48

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

5.15.13 #48

wants to merge 6 commits into from

Conversation

adrianinsaval
Copy link

Checklist

  • Used a personal fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

MNT: Re-rendered with conda-build 3.28.4, conda-smithy 3.31.1, and conda-forge-pinning 2024.03.14.11.25.07
@conda-forge-webservices
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

I do have some suggestions for making it better though...

For recipe:

  •         'Test On Native Only' is deprecated.
    

This was used for disabling testing for cross-compiling.

This has been deprecated in favor of the top-level `test` field.
It is now mapped to `test: native_and_emulated`.
        Failed validating 'deprecated' in schema['properties']['test_on_native_only']:
            {'anyOf': [{'type': 'boolean'}, {'type': 'null'}],
             'default': False,
             'deprecated': True,
             'description': 'This was used for disabling testing for '
                            'cross-compiling.\n'
                            '\n'
                            '```warning\n'
                            'This has been deprecated in favor of the top-level '
                            '`test` field.\n'
                            'It is now mapped to `test: native_and_emulated`.\n'
                            '```',
             'title': 'Test On Native Only'}

        On instance['test_on_native_only']:
            True

@adrianinsaval
Copy link
Author

I tried building locally osx_arm64 but I had trouble because it looks like there are no python2 packages for it. Couldn't run the aarch64 build with docker either due to some weird errors about symlinks:
OSError: [Errno 40] Too many levels of symbolic links: '/home/conda/feedstock_root/build_artifacts/pkg_cache/ncurses-6.4-h0425590_2/share/terminfo/n/ncr260vt300wpp'

I will try now installing python2 via pyenv and adding that to the path to build webengine on osx_arm64 locally

@adrianinsaval
Copy link
Author

I've got builds for osx_644 and linux_64: https://anaconda.org/freecad/qt-webengine/files

still can't figure out how to get a build for osx_arm64, trying to build linux_aarch64 crosscompiled from x86_64

Is it possible to increase the timeout for the ci? maybe it'll work without needing more intervention

@adrianinsaval
Copy link
Author

builds for the 5 platforms, what's the next step @hmaarrfk

@hmaarrfk
Copy link
Contributor

trying to build linux_aarch64 crosscompiled from x86_64

this is what i do too.

Is it possible to increase the timeout for the ci? maybe it'll work without needing more intervention

We have some other big machine CIs, but I don't think it will be enough for this. I'm not very good at using them, and to me they are still rather experimental.

builds for the 5 platforms, what's the next step @hmaarrfk

Did you happen to save the log files?
We would technically need to follow: https://github.com/conda-forge/cfep/blob/main/cfep-03.md

I can help on the linux builds, but windows and OSX i don't have access to machines that can do that.

@hmaarrfk
Copy link
Contributor

I also somewhat want to get:

conda-forge/qt-main-feedstock#245
conda-forge/qt-main-feedstock#244

mereged in before the 5.15 upgrade since it seems that it will unblock the mysql pin or i guess we can do the 5.15.13 pin along with the mysql upgrade if you want to merge in my changes. No need to merge in the rerenders

@hmaarrfk
Copy link
Contributor

hmaarrfk commented Mar 24, 2024

Ok this is really awesome work. I think the way to go will be:

  1. I would like to pin qt-main to 5.15.8 at build time to help downstream packages be compatible with both while we build everything out. Pin qt5 a little harder at compilation time while we build out 5.15.13 conda-forge-pinning-feedstock#5670
  2. Rebase or merge from conda-forge/main your 5.15.13 branch to take in the new changes for mysql 13 and pulseaudio-client 17
  3. Get qt-main 5.15.13 uploaded to conda-forge https://github.com/conda-forge/cfep/blob/main/cfep-03.md Generally we ask for logs.
  4. Once we merge I will create a branch for 5.15.8 on qt-main just to have a reference point for migrations in case of any delays.
  5. Get webengine 5.15.13 uploaded to conda-forge.
  6. Create "qt" 5.15.13 at https://github.com/conda-forge/qt-feedstock
  7. Release the build time pin added on the second point.

@h-vetinari
Copy link
Member

Any updates on this effort here? 🙃

I think it's gonna be necessary to unblock pyside2 for py312, which is the migration I'm looking at right now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants