Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DISCUSS: pause boost migration #6302

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

h-vetinari
Copy link
Member

@h-vetinari h-vetinari commented Aug 17, 2024

Hey @conda-forge/boost @conda-forge/core

I'm seeing way more breakage (from the first couple of PRs) for boost 1.86 than we've seen for 1.84 and 1.82. That impression may be subjective, but in particular it seems that there were a bunch of deprecations executed in boost::filesystem since 1.84 (removed members and even headers) that several projects seem to be running into -- so far 12 out of the feedstocks for which we have PRs:

AFAIU, to a degree the higher cadence for boost was predicated on these migrations running pretty smoothly. Since boost 1.86 is very fresh, we may want to give the ecosystem some time to adapt before we try this. The alternative is that the migration runs more slowly, and/or that we need to patch some things in affected feedstocks.

We can also delete the migrator instead of pausing, this PR is just to discuss that topic. I'm fine with letting it run, pausing it, or deleting it and retrying in a few months.

@h-vetinari h-vetinari requested a review from a team as a code owner August 17, 2024 09:34
@conda-forge-webservices
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe/meta.yaml) and found it was in an excellent condition.

@hmaarrfk
Copy link
Contributor

pausing it would really hurt packages that have already migrated.

i would rather delete to pause.

@beckermr
Copy link
Member

We should let it run, marking it long-term if needed.

@h-vetinari h-vetinari marked this pull request as draft August 17, 2024 19:57
@isuruf
Copy link
Member

isuruf commented Aug 17, 2024

If it's going to be long term, then it'll have to be a matrix of two builds. Otherwise, there'll be a fragmentation of packages for a long time. Will have to choose between deleting (not progrressing) vs two buidls (longer CI)

@h-vetinari
Copy link
Member Author

If it's going to be long term, then it'll have to be a matrix of two builds.

Agreed. Though we've regularly taken 2-3 months for boost migrations without labeling them them longterm. Now that there's a bunch more PRs from the migrator, it doesn't actually look all that bleak. A bunch of them are running into the removed factilities in boost::filesystem, but overall I'd suggest that we give this at least ~2 weeks to see how things go. If we find that we're hopelessly blocked somewhere important, then we can switch to longterm with the double version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants