Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PcapPlusPlus: add version 24.09 #25348

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

seladb
Copy link
Contributor

@seladb seladb commented Sep 21, 2024

Summary

Changes to recipe: pcapplusplus/24.09

Motivation

This is a new version of PcapPlusPlus, released a year after the previous version. It contains a lot of updates and changes

Details

High level summary of the changes: https://github.com/seladb/PcapPlusPlus/releases/tag/v24.09
Full Changelog: v23.09...v24.09


@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

Comment on lines +43 to +45
compiler_version = Version(self.settings.compiler.version)
if self.settings.compiler == "gcc" and compiler_version < "5.1":
raise ConanInvalidConfiguration("PcapPlusPlus requires GCC >= 5.1")
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added this because the build with GCC 5.0 fails:
https://c3i.jfrog.io/c3i/misc/logs/pr/25348/1-linux-gcc-legacy/pcapplusplus/24.09//67b8b30a48b5f4d20d090acd959766840b9443a5-build.txt
https://c3i.jfrog.io/c3i/misc/summary.html?json=https://c3i.jfrog.io/c3i/misc/logs/pr/25348/1-linux-gcc-legacy/pcapplusplus/24.09//summary.json

I'm not sure why initializing an std::array with an initialization list doesn't work, but this thread suggests it might be related to a bug in old GCC versions

This is new code that was added in v24.09 I can add this validation only for v24.09, but I figured that GCC 5 is pretty old so this validation can apply to v23.09 as well. Please let me know what you think

@conan-center-bot
Copy link
Collaborator

Conan v1 pipeline ✔️

All green in build 3 (3fe2d5965ab65ad271ccc8d134481f799230f665):

  • pcapplusplus/23.09:
    Built 10 packages out of 11 (All logs)

  • pcapplusplus/24.09:
    Built 10 packages out of 11 (All logs)


Conan v2 pipeline ✔️

Note: Conan v2 builds are now mandatory. Please read our discussion about it.

All green in build 3 (3fe2d5965ab65ad271ccc8d134481f799230f665):

  • pcapplusplus/24.09:
    Built 5 packages out of 10 (All logs)

  • pcapplusplus/23.09:
    Built 5 packages out of 10 (All logs)

@toge toge mentioned this pull request Sep 21, 2024
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants