Fix using default duration on auto approved requests #748
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Updated the access request hooks to use the Duration returned by the batch ensure API to show how long access was requested for. Where a request is already active, the remaining duration is calculated.
Why?
Access requests that required access to be assigned with Common Fate was returning incorrect values for the duration on the request.
How did you test it?
Ran assume without the change and observed the bug present.
Reran the same command and got the expected output of the default duration.
With specifying duration
When not specifying duration, defaults to using the default duration
Potential risks
Is patch release candidate?
Link to relevant docs PRs