Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve brew alias check #450

Merged
merged 1 commit into from
Jul 31, 2023
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 11 additions & 2 deletions pkg/alias/alias.go
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@ import (
"errors"
"fmt"
"os"
"os/exec"
"strings"

"github.com/AlecAivazis/survey/v2"
Expand All @@ -29,9 +30,10 @@ func init() {
_, color.NoColor = os.LookupEnv("NO_COLOR")
}

const fishAlias = `alias assume="source (brew --prefix)/assume.fish"`
const fishAlias = `alias assume="source /usr/local/bin/assume.fish"`
const fishAliasBrew = `alias assume="source (brew --prefix)/assume.fish"`
const defaultAlias = `alias assume="source assume"`
const devFishAlias = `alias dassume="source (brew --prefix)/dassume.fish"`
const devFishAlias = `alias dassume="source /usr/local/bin/dassume.fish"`
const devDefaultAlias = `alias dassume="source dassume"`

func GetDefaultAlias() string {
Expand All @@ -44,6 +46,13 @@ func GetFishAlias() string {
if build.IsDev() {
return devFishAlias
}

// if 'brew' exists on the path, use the brew prefix rather than /usr/local/bin when installing the alias.
// chrnorm: there's not really a better way to determine if we've been installed with brew or not.
if _, err := exec.LookPath("brew"); err == nil {
return fishAliasBrew
}

return fishAlias
}

Expand Down
Loading