certauth: Fix error handling on a protocol violation

If the other end sends something in a state where it's not expected, one case would not properly terminate the connection or return a proper value. Signed-off-by: Corey Minyard <[email protected]>
cminyard · Jul 8, 2023 · 2305ee7 · 2305ee7
1 parent 5b37134
commit 2305ee7
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/lib/gensio_filter_certauth.c b/lib/gensio_filter_certauth.c
@@ -1333,9 +1333,9 @@ certauth_try_connect(struct gensio_filter *filter, gensio_time *timeout,
 		gca_log_err(sfilter,
 		    "Got server data while client waiting in challenge delay");
 		sfilter->pending_err = GE_NOTREADY;
-		break;
+		goto finish_result;
 	    }
-	    goto out;
+	    goto out_inprogress;
 	}
 
 	set_digest(sfilter);