Update test suite and report failed assertions #78
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clue
reviewed
Jan 18, 2024
There was a problem hiding this comment.
@SimonFrings If it works, it works, I guess? 
Not sure what packages caused this, but given this looks like this only affects legacy PHP versions, I'm okay with this. Let's not waste too much time on legacy versions and instead focus on newer versions!
SimonFrings
force-pushed
the
assertions
branch
from
cf5b0ff
to
e926482
Compare
clue
approved these changes
Feb 1, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request updates the test suite and will now report any failed assertions.
I also had to add
sudo apt install -fin order to fix some packages with unmet dependencies. I'm not quite sure what exactly is causing this (as we didn't change anything in the meantime) and I'm also not convinced if this is the right way to go about this. I invested some time into researching a proper solution but after trying out a few things, this was the only way to get the test suite green again.If there are better options, let's use this ticket as a starting point to discuss this matter.
Builds on top of clue/framework-x#199, reactphp/socket#300 and others.