Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an optional list of IP CIDRs which can access the S3 website. #68

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

razorsedge
Copy link

what

  • We have a need to restrict access to the S3 website. This change allows adding the aws:SourceIp condition to the IAM bucket policy via the new optional trusted_ips variable.

why

  • S3 website are normally public, but we have a need to not allow the work access to the contents. Source IP restrictions help to solve that.

@razorsedge razorsedge requested review from a team as code owners July 27, 2021 15:25
@hans-d hans-d added wip Work in Progress: Not ready for final review or merge stale This PR has gone stale and removed wip Work in Progress: Not ready for final review or merge labels Mar 8, 2024
@hans-d
Copy link

hans-d commented Mar 8, 2024

/terratest

Copy link

mergify bot commented Mar 9, 2024

Thanks @razorsedge for creating this pull request!

A maintainer will review your changes shortly. Please don't be discouraged if it takes a while.

While you wait, make sure to review our contributor guidelines.

Tip

Need help or want to ask for a PR review to be expedited?

Join us on Slack in the #pr-reviews channel.

@mergify mergify bot added triage Needs triage and removed stale This PR has gone stale labels Mar 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
triage Needs triage
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants